Glasgow | May-2025 | Salah Ahmed| Sprint-3

Sprint-3/1-key-implement/1-get-angle-type.js

@@ -1,14 +1,21 @@
+
 // Implement a function getAngleType
 // Build up your function case by case, writing tests as you go
 // The first test and case is written for you. The next case has a test, but no code.
 // Execute this script in your terminal
-// node 1-get-angle-type.js
+//node 1-get-angle-type.js
 // The assertion error will tell you what the expected output is
 // Write the code to pass the test
 // Then, write the next test! :) Go through this process until all the cases are implemented
 
 function getAngleType(angle) {
-   if (angle === 90) return "Right angle";
+  if (angle === 90) return "Right angle";
+  if (angle > 0 && angle < 90) return "Acute angle"; 
+  if (angle > 90 && angle < 180) return "Obtuse angle"; 
+  if (angle === 180) return "Straight angle"; 
+  if (angle > 180 && angle < 360) return "Reflex angle"; 
+  // If the angle is not in any of the above categories, we can return a default value 
+  return "Unknown angle type"; 
    // read to the end, complete line 36, then pass your test here
 }
 
@@ -30,27 +37,35 @@ function assertEquals(actualOutput, targetOutput) {
 // Case 1: Identify Right Angles:
 // When the angle is exactly 90 degrees,
 // Then the function should return "Right angle"
-const right = getAngleType(90);
-assertEquals(right, "Right angle");
+const rightAngle = getAngleType(90);
+assertEquals(rightAngle, "Right angle");
 
 // Case 2: Identify Acute Angles:
 // When the angle is less than 90 degrees,
 // Then the function should return "Acute angle"
-const acute = getAngleType(45);
-assertEquals(acute, "Acute angle");
+const acuteAngle = getAngleType(45);
+assertEquals(acuteAngle, "Acute angle");
 
 // Case 3: Identify Obtuse Angles:
 // When the angle is greater than 90 degrees and less than 180 degrees,
 // Then the function should return "Obtuse angle"
-const obtuse = getAngleType(120);
-// ====> write your test here, and then add a line to pass the test in the function above
+const obtuseAngle = getAngleType(120); 
+assertEquals(obtuseAngle,"Obtuse angle"); 
 
 // Case 4: Identify Straight Angles:
 // When the angle is exactly 180 degrees,
 // Then the function should return "Straight angle"
-// ====> write your test here, and then add a line to pass the test in the function above
+ const straightAngle  = getAngleType(180); 
+ assertEquals(straightAngle,"Straight angle"); 
 
 // Case 5: Identify Reflex Angles:
 // When the angle is greater than 180 degrees and less than 360 degrees,
 // Then the function should return "Reflex angle"
-// ====> write your test here, and then add a line to pass the test in the function above
+ const reflexAngle = getAngleType(200); 
+ assertEquals(reflexAngle,"Reflex angle"); 
+
+// Case 6: Handle Unknown Angles:
+// When the angle is not in any of the above categories (e.g., negative angles or angles greater than or equal to 360 degrees),
+// Then the function should return "Unknown angle type"
+const unknownAngle = getAngleType(400);
+assertEquals(unknownAngle, "Unknown angle type"); 

Sprint-3/1-key-implement/2-is-proper-fraction.js

@@ -8,7 +8,8 @@
 // write one test at a time, and make it pass, build your solution up methodically
 
 function isProperFraction(numerator, denominator) {
-    if (numerator < denominator) return true;
+    return Math.abs(numerator)< Math.abs(denominator) && denominator !== 0;
+
 }
 
 // here's our helper again
@@ -20,7 +21,6 @@ function assertEquals(actualOutput, targetOutput) {
 }
 
 // Acceptance criteria:
-
 // Proper Fraction check:
 // Input: numerator = 2, denominator = 3
 // target output: true
@@ -40,14 +40,20 @@ assertEquals(improperFraction, false);
 // target output: true
 // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
 const negativeFraction = isProperFraction(-4, 7);
-// ====> complete with your assertion
+assertEquals(negativeFraction,true);
 
 // Equal Numerator and Denominator check:
 // Input: numerator = 3, denominator = 3
 // target output: false
 // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
 const equalFraction = isProperFraction(3, 3);
-// ====> complete with your assertion
+assertEquals(improperFraction,false);
 
 // Stretch:
 // What other scenarios could you test for?
+// Zero Numerator check:
+// Input: numerator = 0, denominator = 5
+// target output: true
+// Explanation: The fraction 0/5 is a proper fraction because the numerator is zero, which is less than the denominator. The function should return true.
+const zeroNumerator = isProperFraction(0, 5);
+assertEquals(zeroNumerator, true);

Sprint-3/1-key-implement/3-get-card-value.js

@@ -1,5 +1,4 @@
 // This problem involves playing cards: https://en.wikipedia.org/wiki/Standard_52-card_deck
-
 // You will need to implement a function getCardValue
 // the function takes a single parameter, a string representing a playing card
 // the function should return the numerical value of the card
@@ -8,20 +7,30 @@
 // write one test at a time, and make it pass, build your solution up methodically
 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {
-    if (rank === "A") return 11;
-}
+  if (!card || typeof card !== "string") return "Invalid card format";  
+//extracting the rank of the card
+  const rank = card.slice(0, -1);
+
+//parseInt(rank) and Number(rank) are the same thing. parseInt() is a function that parses a string and returns an integer. If the first character in the string can't be converted into a number, then it returns NaN. Number() is a function that converts a string to a number. If the string can't be converted into a number, then it returns NaN.
+  if (rank === "A") return 11;
+   //For numerical cards, we return the number
+   else if (Number(rank) >= 2 && Number(rank) <= 10) return Number(rank);
+   //For face cards, we return 10
+   else if ( rank === "J" || rank=== "Q" || rank ==="K" ) return 10;
+   //If the card is invalid, we throw an error
+   else return("Invalid card rank.");
+ }
 
 // You need to write assertions for your function to check it works in different cases
 // we're going to use this helper function to make our assertions easier to read
 // if the actual output matches the target output, the test will pass
 function assertEquals(actualOutput, targetOutput) {
-  console.assert(
-    actualOutput === targetOutput,
-    `Expected ${actualOutput} to equal ${targetOutput}`
-  );
+console.assert(
+actualOutput === targetOutput,
+`Expected ${actualOutput} to equal ${targetOutput}`
+);
 }
 // Acceptance criteria:
-
 // Given a card string in the format "A♠" (representing a card in blackjack - the last character will always be an emoji for a suit, and all characters before will be a number 2-10, or one letter of J, Q, K, A),
 // When the function getCardValue is called with this card string as input,
 // Then it should return the numerical card value
@@ -33,19 +42,26 @@ assertEquals(aceofSpades, 11);
 // When the function is called with such a card,
 // Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5).
 const fiveofHearts = getCardValue("5♥");
-// ====> write your test here, and then add a line to pass the test in the function above
+assertEquals(fiveofHearts,5);
 
 // Handle Face Cards (J, Q, K):
 // Given a card with a rank of "10," "J," "Q," or "K",
 // When the function is called with such a card,
 // Then it should return the value 10, as these cards are worth 10 points each in blackjack.
+assertEquals(getCardValue("J♣"), 10);
+assertEquals(getCardValue("Q♦"), 10);
+assertEquals(getCardValue("K♠"), 10);
 
 // Handle Ace (A):
 // Given a card with a rank of "A",
 // When the function is called with an Ace,
 // Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack.
+const aceofDiamonds = getCardValue("A♠");
+assertEquals(aceofDiamonds, 11);
 
 // Handle Invalid Cards:
 // Given a card with an invalid rank (neither a number nor a recognized face card),
 // When the function is called with such a card,
 // Then it should throw an error indicating "Invalid card rank."
+const invalidRank = getCardValue("1♦");
+assertEquals(invalidRank,"Invalid card rank.");

Sprint-3/2-mandatory-rewrite/1-get-angle-type.js

@@ -1,14 +1,14 @@
 function getAngleType(angle) {
   if (angle === 90) return "Right angle";
-  // replace with your completed function from key-implement
-
+  if (angle > 0 && angle < 90) return "Acute angle"; 
+  if (angle > 90 && angle < 180) return "Obtuse angle"; 
+  if (angle === 180) return "Straight angle"; 
+  if (angle > 180 && angle < 360) return "Reflex angle"; 
+  // If the angle is not in any of the above categories, we can return a default value 
+  return "Unknown angle type"; 
+   // read to the end, complete line 36, then pass your test here
 }
-
-
-
-
-
-
+module.exports = getAngleType;
 
 
 // Don't get bogged down in this detail

Sprint-3/2-mandatory-rewrite/1-get-angle-type.test.js

@@ -10,15 +10,48 @@ test("should identify right angle (90°)", () => {
 // Case 2: Identify Acute Angles:
 // When the angle is less than 90 degrees,
 // Then the function should return "Acute angle"
+test("should identify acute angles (less than 90°)", () => {
+  expect(getAngleType(45)).toEqual("Acute angle");
+  expect(getAngleType(1)).toEqual("Acute angle");
+  expect(getAngleType(89)).toEqual("Acute angle");
+});
+
+
 
 // Case 3: Identify Obtuse Angles:
 // When the angle is greater than 90 degrees and less than 180 degrees,
 // Then the function should return "Obtuse angle"
+test("should identify obtuse angles (between 90° and 180°)", () => {
+  expect(getAngleType(120)).toEqual("Obtuse angle");
+  expect(getAngleType(91)).toEqual("Obtuse angle");
+  expect(getAngleType(179)).toEqual("Obtuse angle");
+});
+
 
 // Case 4: Identify Straight Angles:
 // When the angle is exactly 180 degrees,
 // Then the function should return "Straight angle"
+test("should identify straight angle (180°)", () => {
+  expect(getAngleType(180)).toEqual("Straight angle");
+});
+
+
 
 // Case 5: Identify Reflex Angles:
 // When the angle is greater than 180 degrees and less than 360 degrees,
 // Then the function should return "Reflex angle"
+test("should identify reflex angles (between 180° and 360°)", () => {
+  expect(getAngleType(270)).toEqual("Reflex angle");
+  expect(getAngleType(181)).toEqual("Reflex angle");
+  expect(getAngleType(359)).toEqual("Reflex angle");
+});
+
+
+// Case 6: Handle Unknown Angles:
+// When the angle is not in any of the above categories (e.g., negative angles or angles greater than or equal to 360 degrees),
+// Then the function should return "Unknown angle type"
+test("should handle unknown angles (negative or >= 360°)", () => {
+  expect(getAngleType(-45)).toEqual("Unknown angle type");
+  expect(getAngleType(360)).toEqual("Unknown angle type");
+  expect(getAngleType(400)).toEqual("Unknown angle type");
+});

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js

@@ -1,5 +1,6 @@
 function isProperFraction(numerator, denominator) {
-    if (numerator < denominator) return true;
+ return Math.abs(numerator) < Math.abs(denominator) && denominator !== 0;
+
     // add your completed function from key-implement here
 }
 

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.test.js

@@ -1,11 +1,57 @@
 const isProperFraction = require("./2-is-proper-fraction");
-
+// Test cases for isProperFraction function
+// Case 1: Identify Proper Fractions:
+// When the numerator is less than the denominator,
+// Then the function should return true indicating a proper fraction.
 test("should return true for a proper fraction", () => {
   expect(isProperFraction(2, 3)).toEqual(true);
 });
 
 // Case 2: Identify Improper Fractions:
+test("should return false for an improper fraction", () => {
+  expect(isProperFraction(5, 2)).toEqual(false);
+});
 
-// Case 3: Identify Negative Fractions:
+// Case 2: Identify Zero Numerator:
+test("should return true for a zero numerator", () => {
+  expect(isProperFraction(0, 5)).toEqual(true); 
+});
 
-// Case 4: Identify Equal Numerator and Denominator:
+// Case 3: Identify Negative proper Fractions:
+
+test("should return false for a negative improper fraction", () => {
+  expect(isProperFraction(-3, -4)).toEqual(true);
+});
+
+// Case 4: Identify Negative Improper Fractions:
+test("should return true for a negative proper fraction", () => {
+  expect(isProperFraction(-5, -3)).toEqual(false);
+});
+
+// Case 5: Identify Equal Numerator and Denominator:
+test("should return false for equal numerator and denominator", () => {
+  expect(isProperFraction(5,5)).toEqual(false);
+});
+
+// Case 6: Identify Zero Denominator:
+test("should return false for zero denominator", () => {
+  expect(isProperFraction(5, 0)).toEqual(false);
+});
+
+// Case 7: Identify Negative Denominator:
+test("should return true for a negative denominator", () => {
+  expect(isProperFraction(3, -4)).toEqual(true);
+});
+
+// Case 8: invalid input:
+test("should return false for invalid input", () => {
+  expect(isProperFraction("a", 3)).toEqual(false);
+  expect(isProperFraction(2, "b")).toEqual(false);
+  expect(isProperFraction("c", "d")).toEqual(false);
+});
+
+// Case 9: empty input:
+test("should return false for empty input", () => {
+  expect(isProperFraction()).toEqual(false);
+  expect(isProperFraction("", "")).toEqual(false);
+});

Sprint-3/2-mandatory-rewrite/3-get-card-value.js

@@ -1,5 +1,17 @@
+
 function getCardValue(card) {
-    // replace with your code from key-implement
-    return 11;
-}
+  if (!card || typeof card !== "string") return "Invalid card format";  
+//extracting the rank of the card
+  const rank = card.slice(0, -1);
+
+//parseInt(rank) and Number(rank) are the same thing. parseInt() is a function that parses a string and returns an integer. If the first character in the string can't be converted into a number, then it returns NaN. Number() is a function that converts a string to a number. If the string can't be converted into a number, then it returns NaN.
+  if (rank === "A") return 11;
+   //For numerical cards, we return the number
+   else if (Number(rank) >= 2 && Number(rank) <= 10) return Number(rank);
+   //For face cards, we return 10
+   else if ( rank === "J" || rank=== "Q" || rank ==="K" ) return 10;
+   //If the card is invalid, we throw an error
+   else return("Invalid card rank.");
+ }
+
 module.exports = getCardValue;