Glasgow | May-2025 | Salah Ahmed| Sprint-3 #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and error handling
…lue for unknown angles
…s for better clarity
avatarit
added
📅 Sprint 3
jenny-alexander
added
Review in progress
jenny-alexander
suggested changes
Jul 13, 2025
.vscode/extensions.json
Outdated
There was a problem hiding this comment.
Can you remove this file from your PR? It may have been added by mistake. Once your PR has been created, it's a good habit to review the files and ensure that only the required files are included! :)
|
|
||
| // Case 4: Identify Straight Angles: | ||
| // When the angle is exactly 180 degrees, | ||
| // Then the function should return "Straight angle" | ||
| // ====> write your test here, and then add a line to pass the test in the function above | ||
| const Straight = getAngleType(180); |
There was a problem hiding this comment.
It's good practice to name your variables, functions and with a camelCase.
const straight
Further reading: https://dev.to/hassanzohdy/best-practices-for-case-styles-camel-pascal-snake-and-kebab-case-in-node-and-javascript-55oi
There was a problem hiding this comment.
I have changed the names of variables
jenny-alexander
added
Reviewed
… add case for unknown angles
…ero denominator case
… cases for accuracy and coverage
…dinalNumber function
…negative count handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
All the issues have been solved in Sprint 3