Skip to content

LONDON | May-2025 | Aida Eslamimoghadam| Module-Structuring-and-Testing-Data | Sprint-3 #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
28 changes: 24 additions & 4 deletions Sprint-3/1-key-implement/1-get-angle-type.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,15 @@
// Then, write the next test! :) Go through this process until all the cases are implemented

function getAngleType(angle) {
if (angle === 90) return "Right angle";
// read to the end, complete line 36, then pass your test here
if (typeof angle === "number" && isFinite(angle)) {
if (angle <= 0 || angle >= 360) return "Invalid angle";
if (angle < 90) return "Acute angle";
if (angle === 90) return "Right angle";
if (angle < 180) return "Obtuse angle";
if (angle === 180) return "Straight angle";
if (angle < 360) return "Reflex angle";
} else return "Invalid Input";
// read to the end, complete line 36, then pass your test here
}

// we're going to use this helper function to make our assertions easier to read
Expand Down Expand Up @@ -43,14 +50,27 @@ assertEquals(acute, "Acute angle");
// When the angle is greater than 90 degrees and less than 180 degrees,
// Then the function should return "Obtuse angle"
const obtuse = getAngleType(120);
assertEquals(obtuse, "Obtuse angle");
// ====> write your test here, and then add a line to pass the test in the function above

// Case 4: Identify Straight Angles:
// When the angle is exactly 180 degrees,
// Then the function should return "Straight angle"
// ====> write your test here, and then add a line to pass the test in the function above
const strDegree = getAngleType(180);
assertEquals(strDegree, "Straight angle");

// Case 5: Identify Reflex Angles:
// When the angle is greater than 180 degrees and less than 360 degrees,
// Then the function should return "Reflex angle"
// ====> write your test here, and then add a line to pass the test in the function above
const reflex = getAngleType(270);
assertEquals(reflex, "Reflex angle");

// When the angle is less than or equal to 0 or greater than or equal to 360,
// Then the function should return "Invalid angle
const invalidAngle = getAngleType(-20);
assertEquals(invalidAngle, "Invalid angle");

// When the input is invalid,
// Then the function should return "invalid Input"
const invalidInput = getAngleType("Aida");
assertEquals(invalidInput, "Invalid Input");
12 changes: 9 additions & 3 deletions Sprint-3/1-key-implement/2-is-proper-fraction.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// write one test at a time, and make it pass, build your solution up methodically

function isProperFraction(numerator, denominator) {
if (numerator < denominator) return true;
return Math.abs(numerator) < Math.abs(denominator); // false or true
}

// here's our helper again
Expand Down Expand Up @@ -40,14 +40,20 @@ assertEquals(improperFraction, false);
// target output: true
// Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
const negativeFraction = isProperFraction(-4, 7);
// ====> complete with your assertion
assertEquals(negativeFraction, true);

// Equal Numerator and Denominator check:
// Input: numerator = 3, denominator = 3
// target output: false
// Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
const equalFraction = isProperFraction(3, 3);
// ====> complete with your assertion
assertEquals(equalFraction, false);

// Stretch:
// What other scenarios could you test for?

const zeroNumerator = isProperFraction(0, 3);
assertEquals(zeroNumerator, false);

const negativeDenominator = isProperFraction(3, -3);
assertEquals(negativeDenominator, false);
24 changes: 20 additions & 4 deletions Sprint-3/1-key-implement/3-get-card-value.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,15 @@
// write one test at a time, and make it pass, build your solution up methodically
// just make one change at a time -- don't rush -- programmers are deep and careful thinkers
function getCardValue(card) {
if (rank === "A") return 11;
}
const rank = card.slice(0, -1); // Get everything before the suit emoji

if (rank === "A") return 11;
if (["K", "Q", "J", "10"].includes(rank)) return 10;
const number = parseInt(rank);
if (number >= 2 && number <= 9) return number;

throw new Error("Invalid card rank");
}
// You need to write assertions for your function to check it works in different cases
// we're going to use this helper function to make our assertions easier to read
// if the actual output matches the target output, the test will pass
Expand All @@ -22,7 +28,8 @@ function assertEquals(actualOutput, targetOutput) {
}
// Acceptance criteria:

// Given a card string in the format "A♠" (representing a card in blackjack - the last character will always be an emoji for a suit, and all characters before will be a number 2-10, or one letter of J, Q, K, A),
// Given a card string in the format "A♠" (representing a card in blackjack -
// the last character will always be an emoji for a suit, and all characters before will be a number 2-10, or one letter of J, Q, K, A),
// When the function getCardValue is called with this card string as input,
// Then it should return the numerical card value
const aceofSpades = getCardValue("A♠");
Expand All @@ -33,19 +40,28 @@ assertEquals(aceofSpades, 11);
// When the function is called with such a card,
// Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5).
const fiveofHearts = getCardValue("5♥");
// ====> write your test here, and then add a line to pass the test in the function above
assertEquals(fiveofHearts, 5);

// Handle Face Cards (J, Q, K):
// Given a card with a rank of "10," "J," "Q," or "K",
// When the function is called with such a card,
// Then it should return the value 10, as these cards are worth 10 points each in blackjack.

const FaceCard = getCardValue("J♥");
assertEquals(FaceCard, 10);

// Handle Ace (A):
// Given a card with a rank of "A",
// When the function is called with an Ace,
// Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack.

const HandleAce = getCardValue("A♥");
assertEquals(HandleAce, 11);

// Handle Invalid Cards:
// Given a card with an invalid rank (neither a number nor a recognized face card),
// When the function is called with such a card,
// Then it should throw an error indicating "Invalid card rank."

const InvalidCard = getCardValue("B♣");
assertEquals(InvalidCard, 32);
22 changes: 10 additions & 12 deletions Sprint-3/2-mandatory-rewrite/1-get-angle-type.js
Original file line number Diff line number Diff line change
@@ -1,18 +1,16 @@
function getAngleType(angle) {
if (angle === 90) return "Right angle";
// replace with your completed function from key-implement

if (typeof angle === "number" && isFinite(angle)) {
if (angle <= 0 || angle >= 360) return "Invalid angle";
if (angle < 90) return "Acute angle";
if (angle === 90) return "Right angle";
if (angle < 180) return "Obtuse angle";
if (angle === 180) return "Straight angle";
if (angle < 360) return "Reflex angle";
} else return "Invalid input";
}








// Don't get bogged down in this detail
// Jest uses CommonJS module syntax by default as it's quite old
// We will upgrade our approach to ES6 modules in the next course module, so for now
// We will upgrade our approach to ES6 modules in the next course module, so for now
// we have just written the CommonJS module.exports syntax for you
module.exports = getAngleType;
module.exports = getAngleType;
45 changes: 45 additions & 0 deletions Sprint-3/2-mandatory-rewrite/1-get-angle-type.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,60 @@ test("should identify right angle (90°)", () => {
// Case 2: Identify Acute Angles:
// When the angle is less than 90 degrees,
// Then the function should return "Acute angle"
test("should identify acute angle (< 90°)", () => {
expect(getAngleType(45)).toEqual("Acute angle");
expect(getAngleType(10)).toEqual("Acute angle");
expect(getAngleType(1.23)).toEqual("Acute angle");
});

// Case 3: Identify Obtuse Angles:
// When the angle is greater than 90 degrees and less than 180 degrees,
// Then the function should return "Obtuse angle"
test("should identify obtuse angle (90° < angle < 180°)", () => {
expect(getAngleType(120)).toEqual("Obtuse angle");
expect(getAngleType(170)).toEqual("Obtuse angle");
expect(getAngleType(145.87)).toEqual("Obtuse angle");
});

// Case 4: Identify Straight Angles:
// When the angle is exactly 180 degrees,
// Then the function should return "Straight angle"
test("should identify straight angle (180°)", () => {
expect(getAngleType(180)).toEqual("Straight angle");
});

// Case 5: Identify Reflex Angles:
// When the angle is greater than 180 degrees and less than 360 degrees,
// Then the function should return "Reflex angle"
test("should identify reflex angle (180° < angle < 360°)", () => {
expect(getAngleType(300)).toEqual("Reflex angle");
expect(getAngleType(359.999)).toEqual("Reflex angle");
expect(getAngleType(180.001)).toEqual("Reflex angle");
});

// When the angle is less than or equal to 0 or greater than or equal to 360,
// Then the function should return "Invalid angle

test("should return 'Invalid angle' for angles ≤ 0 or ≥ 360", () => {
expect(getAngleType(0)).toEqual("Invalid angle");
expect(getAngleType(-12)).toEqual("Invalid angle");
expect(getAngleType(450)).toEqual("Invalid angle");
});

// Case: Angles near important limits
// These tests make sure the function works correctly
// for values very close to 90° and 360°
test("should return 'Acute angle' for angle just below 90°", () => {
expect(getAngleType(89.999)).toEqual("Acute angle");
});
test("should return 'Reflex angle' for angle just below 360°", () => {
expect(getAngleType(359.999999)).toEqual("Reflex angle");
});

// Case: For invalid input
// Should return "Invalid input" for non-numeric or missing values
test("should return 'Invalid input' for invalid", () => {
expect(getAngleType("Aida")).toEqual("Invalid input");
expect(getAngleType("")).toEqual("Invalid input");
expect(getAngleType()).toEqual("Invalid input");
});
5 changes: 2 additions & 3 deletions Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
function isProperFraction(numerator, denominator) {
if (numerator < denominator) return true;
// add your completed function from key-implement here
return Math.abs(numerator) < Math.abs(denominator); // false or true
}

module.exports = isProperFraction;
module.exports = isProperFraction;
9 changes: 9 additions & 0 deletions Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,16 @@ test("should return true for a proper fraction", () => {
});

// Case 2: Identify Improper Fractions:
test("should return false for a Improper fraction", () => {
expect(isProperFraction(4, 3)).toEqual(false);
});

// Case 3: Identify Negative Fractions:
test("should return true for a Negative fraction", () => {
expect(isProperFraction(-3, 6)).toEqual(true);
});

// Case 4: Identify Equal Numerator and Denominator:
test("should return false for Equal Numerator and Denominator", () => {
expect(isProperFraction(6, 6)).toEqual(false);
});
18 changes: 15 additions & 3 deletions Sprint-3/2-mandatory-rewrite/3-get-card-value.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
function getCardValue(card) {
// replace with your code from key-implement
return 11;
const rank = card.slice(0, -1); // Get everything before the suit emoji

if (rank === "A") return 11;
if (["K", "Q", "J", "10"].includes(rank)) return 10;
const number = parseInt(rank);
if (number >= 2 && number <= 9) return number;
Comment on lines +6 to +7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In JavaScript, strings that represent valid numeric literals in the language can be safely converted to equivalent numbers or parsed into integers. For examples, "0x02", "2.1", or "00_02".

Does your function return the value you expected from each of the following function calls?

getCardValue("0x02♠");
getCardValue("2.1♠");
getCardValue("00_02♠");

getCardValue("2XYZ♠");

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code returns 2 for ‘0x02♠’, ‘2.1♠’, and ‘2XYZ♠’, but it throws an error for ‘00_02 because it can’t read underscores (00_02) ==> becomes NaN, so it gives an error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should any of them of them be treated as valid card rank?


throw new Error("Invalid card rank");
}
module.exports = getCardValue;
module.exports = getCardValue;

console.log(getCardValue("2XYZ♠")); // ==> 2
console.log(getCardValue("0x02♠")); // ==> 2
console.log(getCardValue("2.1♠")); // ==> 2
// console.log(getCardValue("00_02♠")); //==> Invalid card rank
console.log(getCardValue("2.5♥"));
41 changes: 38 additions & 3 deletions Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,46 @@
const getCardValue = require("./3-get-card-value");
let cardList = ["♥", "♣", "♠", "♦"];
let faceCardList = ["J", "Q", "K"];
let invalidCards = ["B♣", "11♠", "0♣", "5", "♠", "_", ""];

test("should return 11 for Ace of Spades", () => {
const aceofSpades = getCardValue("A♠");
expect(aceofSpades).toEqual(11);
});
const aceofSpades = getCardValue("A♠");
expect(aceofSpades).toEqual(11);
});

// Case 2: Handle Number Cards (2-10):

for (let item of cardList) {
for (let i = 2; i <= 10; i++) {
test(`should return ${i} for ${i}${item}`, () => {
const fiveofHearts = getCardValue(`${i}${item}`);
expect(fiveofHearts).toEqual(i);
});
}
}

// Case 3: Handle Face Cards (J, Q, K):
for (let face of faceCardList) {
for (let item of cardList) {
test(`should return 10 for ${face}${item}`, () => {
const FaceCard = getCardValue(`${face}${item}`);
expect(FaceCard).toEqual(10);
});
}
}

// Case 4: Handle Ace (A):
for (let item of cardList) {
test(`should return 11 for Ace of ${item}`, () => {
const HandleAce = getCardValue(`A${item}`);
expect(HandleAce).toEqual(11);
});
}

// Case 5: Handle Invalid Cards:

for (let invCard of invalidCards) {
test(`should throw error for invalid card ${invCard}`, () => {
expect(() => getCardValue(invCard)).toThrow("Invalid card rank");
});
}
10 changes: 8 additions & 2 deletions Sprint-3/3-mandatory-practice/implement/count.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
function countChar(stringOfCharacters, findCharacter) {
return 5
let count = 0;
for (let i = 0; i < stringOfCharacters.length; i++) {
if (stringOfCharacters[i] === findCharacter) {
count++;
}
}
return count;
}

module.exports = countChar;
module.exports = countChar;
7 changes: 7 additions & 0 deletions Sprint-3/3-mandatory-practice/implement/count.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,10 @@ test("should count multiple occurrences of a character", () => {
// And a character char that does not exist within the case-sensitive str,
// When the function is called with these inputs,
// Then it should return 0, indicating that no occurrences of the char were found in the case-sensitive str.

test("should return 0 when character does not exist", () => {
const str = "Hello";
const char = "E";
const count = countChar(str, char);
expect(count).toEqual(0);
});
21 changes: 19 additions & 2 deletions Sprint-3/3-mandatory-practice/implement/get-ordinal-number.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,22 @@
function getOrdinalNumber(num) {
return "1st";
const lastTwo = num % 100;
const lastDigit = num % 10;
if (lastTwo >= 11 && lastTwo <= 13) {
// for 11 , 12, 13
return num + "th";
}

switch (lastDigit) {
case 1:
return num + "st";
case 2:
return num + "nd";
case 3:
return num + "rd";
default:
return num + "th";
}
}

module.exports = getOrdinalNumber;
module.exports = getOrdinalNumber;
console.log(getOrdinalNumber(2));
Loading