LONDON | May-2025 | Aida Eslamimoghadam| Module-Structuring-and-Testing-Data | Sprint-3

[aydaeslami]

Self checklist

• I have committed my files one by one, on purpose, and for a reason

• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME

• I have tested my changes

• My changes follow the style guide

• My changes meet the requirements of this task

• Completed all tasks mentioned in the requirements

• Reviewed the implementation with ChatGPT to ensure correctness

UPDATE

Hi CJ,
Thanks for your reviews and suggestions. I’ve updated my code. Please let me know if I need to change anything else.
Thanks a million!

Changelist

• Updated tests to use loops and scenario lists
• Added more test scenarios
• Added Invalid angle cases

[cjyuan]

In JavaScript, strings that represent valid numeric literals in the language can be safely converted to equivalent numbers or parsed into integers. For examples, "0x02", "2.1", or "00_02".

Does your function return the value you expected from each of the following function calls?

getCardValue("0x02♠");
getCardValue("2.1♠");
getCardValue("00_02♠");

getCardValue("2XYZ♠");

[aydaeslami]

This code returns 2 for ‘0x02♠’, ‘2.1♠’, and ‘2XYZ♠’, but it throws an error for ‘00_02 because it can’t read underscores (00_02) ==> becomes NaN, so it gives an error.

[cjyuan]

Should any of them of them be treated as valid card rank?

[cjyuan]

@fernandamelov I am sorry that I didn't notice the "Review in progress" label when I started the review.

[cjyuan]

Changes look good. Well done.

Sprint-3/2-mandatory-rewrite/3-get-card-value.js could still use some improvement if you want to consider those ranks I suggested as invalid. I will go ahead and mark this PR as complete first.

I won't get notified when you changed the PR description, and I almost missed what you changed in the PR description.

Leaving comments and changing labels will do. If needed, you can also tag me.