Glasgow | ITP-May | Salah Ahmed | Module-Structuring-and-Testing-Data | Sprint-2

[avatarit]

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

I have fixed the errors and solve the issues in sprint 2

[LonMcGregor]

Hi, I've went through your submission. Most of it is good, however there were a couple of files where I've added some feedback for you to work on.
Also, did you commit all of the Sprint 2 exercises in one single commit? What impact do you think big commits might have when you are working on a programming project?

[LonMcGregor]

It's good to see you doing tests to figure things out. Should this testing be included in your pull request?

[LonMcGregor]

a) You've correctly identified 2 function calls. How did you decide these were functions? Can you see any others?
b) Good fix. Can you see a way to make the coding style of the fixed code consistent with the rest of the program?
c) and d) Good!
e) Good explanation. Can you think of a reason why you would want to remove the comma from the number before converting it?

[LonMcGregor]

b) What is line 10 doing? How would you describe that kind of code?
f) The calculations may work, but can you think of any cases where the formatted result might not look quite right?

[LonMcGregor]

You correctly identify the effect of prompt - can you think of a reason why you would want to use this?

[LonMcGregor]

You found that the type of console is an 'object' - but can you think of a better way to describe what console stores? What is the purpose of the object?

[LonMcGregor]

Did you do the prediction question first? (Line 4)

Can you see a way to change the fixed function to be more concise?

[LonMcGregor]

Good solution.

1. Do you know what / / represents?
2. Can you think of any ways you might clean up the coding style of your function?

[LonMcGregor]

Good parameter name. Can you see any areas where you could improve the code style? Can you think of any extreme cases where the code might not work right?

[LonMcGregor]

a) Good
b) and c) Are you sure? What is the input parameter of this function? What will pad first be used on?
d) and e) good explanation

[LonMcGregor]

Good solution! Good idea to add concise comments indicating the edge cases in your if branches.

[LonMcGregor]

Good work on this sprint. Well done expanding on the points raised. You can close this review now.