Skip to content

Include sea ice in the one_degree_simulation.jl #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

simone-silvestri
Copy link
Collaborator

I think, now that the coupling is working we could be ambitious and add the sea ice to the examples. It will help us go forward.

@simone-silvestri simone-silvestri added the build docs Add this label to built the docs in a PR label Jun 8, 2025
@simone-silvestri
Copy link
Collaborator Author

Let's see how the example looks like.

@glwagner
Copy link
Member

glwagner commented Jun 8, 2025

I think this makes sense, because if you are going to do a simulation that includes the arctic on a TripolarGrid you probably want to include sea ice. If you want to do a simulation without sea ice, it's probably better to do a latitude longitude grid with restoring instead.

@simone-silvestri
Copy link
Collaborator Author

Hmm it looks like the simulation crashes with the addition of sea ice

Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.25%. Comparing base (09edc1f) to head (819edcd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
- Coverage   14.35%   14.25%   -0.11%     
==========================================
  Files          48       48              
  Lines        2835     2835              
==========================================
- Hits          407      404       -3     
- Misses       2428     2431       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simone-silvestri
Copy link
Collaborator Author

The reason for the crash might be CliMA/ClimaSeaIce.jl#79. I forgot I was using that branch for the omip simulation but I had not opened a PR yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build docs Add this label to built the docs in a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants