-
Notifications
You must be signed in to change notification settings - Fork 18
Include sea ice in the one_degree_simulation.jl
#559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Let's see how the example looks like. |
I think this makes sense, because if you are going to do a simulation that includes the arctic on a |
Hmm it looks like the simulation crashes with the addition of sea ice |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
==========================================
- Coverage 14.35% 14.25% -0.11%
==========================================
Files 48 48
Lines 2835 2835
==========================================
- Hits 407 404 -3
- Misses 2428 2431 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The reason for the crash might be CliMA/ClimaSeaIce.jl#79. I forgot I was using that branch for the omip simulation but I had not opened a PR yet. |
I think, now that the coupling is working we could be ambitious and add the sea ice to the examples. It will help us go forward.