Add UpwindBiasedGradient operator #2345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisYatunin
force-pushed
the
dy/upwind_gradient
branch
from
d867d88 to
e34abc1
Compare
|
This operator has been integration tested in CliMA/ClimaAtmos.jl#3843, with the latest successful CI run from 07/02/25 available here. The unit tests in this PR are also showing the expected convergence rates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
UpwindBiasedGradientoperator that can be used in CliMA/ClimaAtmos.jl#3843 (see Tapio's comment). This operator computes a first-order gradient with either left biasing or right biasing, depending on the direction of an associated velocity field. A convergence and correctness test has also been added.