Skip to content

Add a seed for random inputs in UpwindBiasedGradient test #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

dennisYatunin
Copy link
Member

This PR adds a random seed to the convergence test for UpwindBiasedGradient from #2345. There have been several random CI failures since I added that test, which can be avoided by using an appropriate seed for the randomized inputs. It is unfortunate that the convergence order error is not negligibly small for all possible inputs, but it makes sense that there will always be certain seeds that lead to arbitrarily high errors.

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

@dennisYatunin dennisYatunin enabled auto-merge July 15, 2025 01:22
@dennisYatunin dennisYatunin merged commit 5f968c8 into main Jul 15, 2025
34 checks passed
@dennisYatunin dennisYatunin deleted the dy/gradient_test_seed branch July 15, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant