Remove viscosity, diffusivity, and mixing length from precomputed quantities #3864
+372
−230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costachris
force-pushed
the
cc/remove_precomputed_quants_v1
branch
22 times, most recently
from
f24e86b to
3285f73
Compare
tapios
approved these changes
Jun 24, 2025
| ᶜK_u = ᶜK_h | ||
| else | ||
| (; ᶜtke⁰,) = p.precomputed | ||
| ᶜmixing_length = p.scratch.ᶜtemp_scalar_6 |
There was a problem hiding this comment.
@dennisYatunin Is there some way to encapsulate this recurring materialize in scratch pattern, so it's easy to remove later?
costachris
force-pushed
the
cc/remove_precomputed_quants_v1
branch
2 times, most recently
from
7d337cb to
41acb83
Compare
trontrytel
reviewed
Jun 25, 2025
costachris
force-pushed
the
cc/remove_precomputed_quants_v1
branch
3 times, most recently
from
78132f4 to
186d567
Compare
4 tasks
costachris
force-pushed
the
cc/remove_precomputed_quants_v1
branch
19 times, most recently
from
82f4863 to
4970b80
Compare
costachris
force-pushed
the
cc/remove_precomputed_quants_v1
branch
3 times, most recently
from
3a02be9 to
e43e61f
Compare
costachris
force-pushed
the
cc/remove_precomputed_quants_v1
branch
2 times, most recently
from
d163cdd to
4c10eb7
Compare
costachris
force-pushed
the
cc/remove_precomputed_quants_v1
branch
from
4c10eb7 to
ca4cde6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove viscosity, diffusivity, and mixing length from precomputed quantities