Fix unrolling over field broadcast arguments #2350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisYatunin
force-pushed
the
dy/broadcast_argument_unrolling
branch
from
886808b to
39a7ee9
Compare
dennisYatunin
force-pushed
the
dy/broadcast_argument_unrolling
branch
from
39a7ee9 to
66c0a84
Compare
costachris
approved these changes
Jun 28, 2025
|
This has been tested in https://buildkite.com/clima/climaatmos-ci/builds/24936, and it appears to successfully fix inference issues in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overrides the recursive unrolling used in
Base.Broadcast.combine_styleswith manual unrolling, which will hopefully allow us to avoid inference issues in broadcast expressions with many arguments. Specifically, this should allow us to fix the allocations and inference failures in CliMA/ClimaAtmos.jl#3864.