Add sedimentation of rhoa, q_tot and moisture tracers to edmf #3843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tapios
reviewed
Jun 8, 2025
tapios
approved these changes
Jun 8, 2025
| @. Yₜ.c.sgsʲs.:($$j).ρa += vtt | ||
|
|
||
| # q_tot and moisture tracers advective form advection with sedimentation velocity | ||
| va = vertical_advection(ᶠwₗ³ʲs, Y.c.sgsʲs.:($j).q_liq, edmfx_upwinding) |
There was a problem hiding this comment.
Can we write the following block (and the preceding one above) as a loop of condensate species, so we do not need to repeat the same pattern so many times? (And can also add other condensate species, e.g., graupel, more easily later if we really want to.)
There was a problem hiding this comment.
Yes, I'll do it after I'm done with the PR. It's easier for me to debug when everything is written out like this. But I'll turn it into a concise loop over tracers and velocities for better readability afterwards
4 tasks
trontrytel
force-pushed
the
aj/edmf_1M_sedimentation
branch
from
19ce5d4 to
ec4862a
Compare
trontrytel
force-pushed
the
aj/edmf_1M_sedimentation
branch
from
ec4862a to
cc50357
Compare
trontrytel
force-pushed
the
aj/edmf_1M_sedimentation
branch
from
cc50357 to
6974fc5
Compare
trontrytel
force-pushed
the
aj/edmf_1M_sedimentation
branch
from
6974fc5 to
e805a8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the sedimentation terms due to precipitation to rhoa, q_tot and other moisture tracers. Here are the derivation notes. It would be great if someone could check my math.
TODO (but possibly in another PR)
hadvectionlazyexpressions. For example for thewof all the moisture tracersI think this is as smooth as I can make the updraft to be. We will need some additional detrainment/flux term to move mass from updrafts to the environment to ensure that the environmental values don't go too negative from advection. As is, right now, we don't have any means to ensure positivity in the environment while solving prognostic advection on the grid mean and updraft.
RICO:
summary.pdf