Skip to content

take 2 of ccache for emscripten build #71439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Feb 18, 2024
Merged

take 2 of ccache for emscripten build #71439

merged 22 commits into from
Feb 18, 2024

Conversation

nornagon
Copy link
Contributor

@nornagon nornagon commented Feb 2, 2024 •
edited
Loading

Summary

None

Purpose of change

ccache wasn't actually being invoked. Also, per https://github.com/emscripten-core/emscripten/pull/13681/files, ccache + emscripten apparently needs a special fork to work correctly.

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added Code: Build Issues regarding different builds and build environments Code: Tooling Tooling that is not part of the main game but is part of the repo. labels Feb 2, 2024
@nornagon nornagon changed the title wip fix ccache for emscripten build Feb 2, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Feb 2, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 2, 2024
@nornagon nornagon mentioned this pull request Feb 3, 2024
Merged
@nornagon nornagon changed the title fix ccache for emscripten build take 2 of ccache for emscripten build Feb 7, 2024
@nornagon nornagon marked this pull request as ready for review February 16, 2024 22:51
@nornagon
Copy link
Contributor Author

Alright, this is finally working. Found a couple of bugs in emsdk and the ccache fork while I was at it, see emscripten-core/emsdk#1345 and juj/ccache#3. The weird $PATH stuff is working around the emsdk bug, and EM_CONFIG needs to be set to prevent the forked ccache from crashing.

@Maleclypse Maleclypse merged commit d5b8d5a into CleverRaven:master Feb 18, 2024
@BrettDong BrettDong mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Build Issues regarding different builds and build environments Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nornagon @Maleclypse