use ccache for emscripten builds #71422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Code: Build
|
Doesn't seem like it worked, the last few uploads from master had a ccache size of all of 8kb. |
make actions still used emcc directly. |
|
yeah i saw that, see #71439 for some ongoing diagnosis |
nornagon
added a commit
to nornagon/Cataclysm-DDA
that referenced
this pull request
Feb 5, 2024
This reverts commit 03a693c.
ZhilkinSerg
pushed a commit
that referenced
this pull request
Feb 5, 2024
nornagon
added a commit
to nornagon/Cataclysm-DDA
that referenced
this pull request
Feb 7, 2024
…rRaven#71524) This reverts commit ef75f20.
Maleclypse
pushed a commit
that referenced
this pull request
Feb 18, 2024
* wip * fix * fix * fix? * what if we don't try to invoke ccache directly? * more debugging * try, try again * wip * ??? * ???? * --verbose not supported? * more fix * maybe not having ccache in the activate line means it gets deactivated..? * Reapply "use ccache for emscripten builds (#71422)" (#71524) This reverts commit ef75f20. * explicitly invoke ccache i guess * fix makefile * maybe CCACHE_SLOPPINESS is causing issues? * emcc ccache seems to have a problem with EM_CONFIG not being set i think * use CCACHEBIN for sloppiness * add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Should hopefully speed up the emscripten build in most cases
Describe the solution
Cargo culted from the matrix build
Describe alternatives you've considered
Testing
Additional context