Skip to content

Fix panic in prescan when Trivy reports no OS metadata #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2025
Merged

Fix panic in prescan when Trivy reports no OS metadata #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions pkg/flow/spsOption.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,25 +84,30 @@ func (o SpsOption) Run(ctx context.Context) error {
return nil, nil, err
}

switch copa.SupportedOS(string(r.Metadata.OS.Family)) {
case true:
if r.Metadata.OS == nil {
// Distroless/scratch images report no OS; nothing Copa can patch.
slog.Warn("Image has no detected OS (likely distroless/scratch). The image will not be patched.",
slog.String("image", ref),
)
push = append(push, i)
} else if !copa.SupportedOS(string(r.Metadata.OS.Family)) {
slog.Warn("Image contains an unsupported OS. The image will not be patched.",
slog.String("image", ref),
slog.String("os", string(r.Metadata.OS.Family)),
)
push = append(push, i)
} else {
// filter images with no os-pkgs as copa has nothing to do
switch trivy.ContainsOsPkgs(r.Results) {
case true:
if trivy.ContainsOsPkgs(r.Results) {
slog.Debug("Image does contain os-pkgs vulnerabilities",
slog.String("image", ref))
patch = append(patch, i)
case false:
} else {
slog.Warn("Image does not contain os-pkgs. The image will not be patched.",
slog.String("image", ref),
)
push = append(push, i)
}
case false:
slog.Warn("Image contains an unsupported OS. The image will not be patched.",
slog.String("image", ref),
)
push = append(push, i)
}

// Write report to filesystem
Expand Down
Loading