Fix panic in prescan when Trivy reports no OS metadata #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a
nil pointer dereferencepanic inprescanwhen processing images that do not contain OS metadata (e.g., distroless or scratch-based images such asquay.io/prometheus/prometheus:v2.48.0).Problem
Previously,
prescanassumed thatr.Metadata.OSwas always non-nil. When Trivy reports no OS metadata, Helmper panics at runtime:panic: runtime error: invalid memory address or nil pointer dereferenceFix
r.Metadata.OSinprescan.push), rather than attempting to evaluate unsupported OS or patch logic.Impact
Testing
.goreleaser.yaml)helmper.yamlconfiguration file with prometheus-community chart (5 of the 6 images contain 0 OS vulns).