Skip to content

fix: add console warning when creating score using generationId #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1368,6 +1368,11 @@ export class API {
* @returns A promise that resolves to an array of `Score` instances populated with the created scores' data.
*/
async createScores(scores: Score[]): Promise<Score[]> {
if (scores.some((score) => score.generationId)) {
console.warn(
'generationId is deprecated and will be removed in a future version, please use stepId instead'
);
}
const query = createScoresQueryBuilder(scores);
const variables = variablesBuilder(scores);

Expand Down Expand Up @@ -1426,7 +1431,11 @@ export class API {
}
}
`;

if (variables.generationId) {
console.warn(
'generationId is deprecated and will be removed in a future version, please use stepId instead'
);
}
const result = await this.makeGqlCall(query, variables);
return new Score(result.data.createScore);
}
Expand Down
Loading