Skip to content

fix: add console warning when creating score using generationId #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: add console warning when creating score using generationId #76

merged 1 commit into from
Oct 31, 2024

Conversation

desaxce
Copy link
Contributor

@desaxce desaxce commented Oct 28, 2024

Changes:

  • add console warning -> maybe there's a better way to log errors in TS

To test:

  • create a score with createScore passing in a generationid -> check warning shows
  • do the same with createScores API

@desaxce desaxce merged commit 6afc8b2 into main Oct 31, 2024
2 checks passed
@desaxce desaxce deleted the hugues/add-warning-generationId branch October 31, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matthieu-OD Matthieu-OD Matthieu-OD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@desaxce @Matthieu-OD