Skip to content

TypeScript SDK - fix: use promptType in datasetitem metadata #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 18, 2024
Merged

TypeScript SDK - fix: use promptType in datasetitem metadata #30

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b894027
fix: type -> promptType on dataset item metadata and in createGenerat…
desaxce Jun 12, 2024
9afbac4
fix: map to type instead of promptType
desaxce Jun 13, 2024
490efe7
fix: revert back to llm
desaxce Jun 13, 2024
39a8304
fix: revert type/promptType breaking change
desaxce Jun 14, 2024
3d79960
fix: revert blankspace
desaxce Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,7 +760,7 @@ export class API {
mutation CreateGeneration($generation: GenerationPayloadInput!) {
createGeneration(generation: $generation) {
id,
type
promptType
}
}
`;
Expand All @@ -770,7 +770,11 @@ export class API {
};

const response = await this.makeGqlCall(mutation, variables);
return response.data.createGeneration as PersistedGeneration;
const stepGeneration = response.data.createGeneration;
return {
id: stepGeneration.id,
promptType: stepGeneration.promptType
} as PersistedGeneration;
}

// Thread
Expand Down
6 changes: 3 additions & 3 deletions tests/integration/api.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,8 +546,8 @@ describe('End to end tests for the SDK', function () {

await step
.step({
name: 'gpt-4',
type: 'llm',
name: 'agent',
type: 'run',
input: { content: 'hello' },
output: { content: 'hello!' }
})
Expand Down Expand Up @@ -598,7 +598,7 @@ describe('End to end tests for the SDK', function () {
expect(datasetItem.createdAt).not.toBeNull();
expect(datasetItem.input).not.toBeNull();
expect(datasetItem.expectedOutput).not.toBeNull();
expect(datasetItem.metadata.type).toBe('CHAT');
expect(datasetItem.metadata.promptType).toBe('CHAT');
});
});

Expand Down
Loading