Skip to content

TypeScript SDK - fix: use promptType in datasetitem metadata #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 18, 2024
Merged

TypeScript SDK - fix: use promptType in datasetitem metadata #30

merged 5 commits into from
Jun 18, 2024

Conversation

desaxce
Copy link
Contributor

@desaxce desaxce commented Jun 12, 2024 •
edited
Loading

Fixes for the migration:

  • handle the promptType to remap it to a type
  • replace llm to run since we need to pass either messages or prompt for LLM steps

End-to-end tests should pass against the migration branch.

@desaxce desaxce changed the title fix: type -> promptType on dataset item metadata and in createGeneration return type TypeScript SDK = fix: type -> promptType on dataset item metadata and in createGeneration return type Jun 12, 2024
@desaxce desaxce changed the title TypeScript SDK = fix: type -> promptType on dataset item metadata and in createGeneration return type TypeScript SDK - fix: use promptType and switch llm steps to be run Jun 12, 2024
Dam-Buty
Dam-Buty reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@Dam-Buty Dam-Buty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one doubt

@desaxce desaxce changed the title TypeScript SDK - fix: use promptType and switch llm steps to be run TypeScript SDK - fix: use promptType in datasetitem metadata Jun 18, 2024
@desaxce desaxce requested a review from Dam-Buty June 18, 2024 08:06
Dam-Buty
Dam-Buty approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@Dam-Buty Dam-Buty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ALL IN ♦️

@desaxce desaxce merged commit 4ee6b89 into main Jun 18, 2024
2 checks passed
@desaxce desaxce deleted the hugues/gen-to-step-migration branch June 18, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dam-Buty Dam-Buty Dam-Buty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@desaxce @Dam-Buty