-
Notifications
You must be signed in to change notification settings - Fork 70
Categorise recipes + rename recipes and tutorials to dishes and cooking lessons #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1e55c5d
to
5875aef
Compare
Sorry, a bit of fiddling around but this should give you an idea of how to do it. |
T H A N K S! |
@julia-neme, @adele-morrison, @edoddridge: could someone have a look/review? A preview of the docs is found at https://cosima-recipes--529.org.readthedocs.build/en/529/ |
I quickly did a split between mains and appetisers but I'm not strong about it! We can also change later. |
My biggest concern with this is that the tutorials don't fit the menu analogy. I guess I would have expected them to be in the appetisers? |
How about:
|
These categories are yummy! Thanks @navidcy and @angus-g. This is off topic but could the docs be more visible somehow? Shamefully, today is the first time I've looked at it. I've always just read the README and then looked at tutorials etc. One option I guess is to move all the README content into the docs and only have a link to the docs on the README (reduces admin burden too). Just a thought. |
But the README does link to the docs! All these are links to the docs: ![]() |
Co-authored-by: Angus Gibson <angus@agibson.me>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
If we are doing that we don't need subcategories, right? At the moment the "dishes" are under "Recipes" as a subcategory:
|
Yikes, mea culpa -- I totally missed that! |
A lot of people miss the docs or seem to have a tendency to avoid them and I don't know why! |
@edoddridge I renamed the Tutorials to "Cooking Lessons 101"; how's that? |
I think this PR is ready for review! |
Looks good to me. It fits the theme nicely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
.. nbgallery:: | ||
:caption: Tutorials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice catch - harmonising and simplifying the look. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
I'll merge. If there is disagreements regarding a dish being a main while being put in the appetisers we can adjust later! |
@angus-g I tried to add subcategories to recipes in anticipation of #523 and moving towards #182.
But I failed... I did a few other attempts locally that also failed. Do you know how to achieve this?
I'm thinking that Recipes should have subcategories eg
Or if you figure how to set up the categorisation it'd be easy to tweak laters.
cc @julia-neme