Skip to content

update regional mom6 notebook to work with regional mom6 v1.0.1 #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmr0
Copy link

@mmr0 mmr0 commented Jun 10, 2025

  1. Updated to use regional-mom6 v1.0.1.
  2. Changed the ACCESS-OM2 model experiment used to produce the boundary forcing as well as the time period, to be consistent with the regional model setup instructions here

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mmr0
Copy link
Author

mmr0 commented Jun 10, 2025

@navidcy

@navidcy
Copy link
Collaborator

navidcy commented Jun 10, 2025

Great! Thanks!

It's a good opportunity to force myself install the environment on xp65 to review this. @mmr0 could you point me to the instructions to do so?

@navidcy navidcy added the 🛸 updating An existing notebook needs to be updated label Jun 10, 2025
@navidcy navidcy self-requested a review June 10, 2025 02:24
@mmr0
Copy link
Author

mmr0 commented Jun 10, 2025

Thanks @navidcy. Some info here:

https://forum.access-hive.org.au/t/access-nri-analysis3-conda-environments-new-release-announcement/4377

When using Australian Research Environment (ARE), add gdata/xp65 to “Storage”, /g/data/xp65/public/modules/ to “Module directories” (under “Advanced options”), and add conda/analysis3 to “Modules”. Additionally, users can switch kernels inside their ARE JupyterLab instance to select the appropriate environment.

Copy link

review-notebook-app bot commented Jun 10, 2025

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2025-06-10T03:24:38Z
----------------------------------------------------------------

Line #1.    client = Client(threads_per_worker = 7)

why change this to 7?


mmr0 commented on 2025-06-10T03:54:40Z
----------------------------------------------------------------

This is a hangover from my larger domain where I needed more memory (per worker) to run `setup_initial_condition'. So, 7 is not a special number. It might be more useful to revert to 1 but add a comment. Here's the relevant thread:

COSIMA/regional-mom6#215 (comment)

Copy link

review-notebook-app bot commented Jun 10, 2025

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2025-06-10T03:24:39Z
----------------------------------------------------------------

Line #1.    #expt_name = "tassie-access-om2-forced"

why commented out code? doesn't add anything


Copy link

review-notebook-app bot commented Jun 10, 2025

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2025-06-10T03:24:39Z
----------------------------------------------------------------

Line #7.    # longitude_extent = [131, 158]

we don't need commented out code; just have one domain here

there is no need to keep history of what was "the original domain" and then "the post-original domain" and what not; this is just an example it's not the reference case that all researchers are using


Copy link

review-notebook-app bot commented Jun 10, 2025

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2025-06-10T03:24:40Z
----------------------------------------------------------------

What are all those xarray warnings? They seem scary? Should we deal with this? @anton-seaice, @dougiesquire do you have an opinion?


Copy link

review-notebook-app bot commented Jun 10, 2025

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2025-06-10T03:24:41Z
----------------------------------------------------------------

Line #5.    #experiment = catalog["01deg_jra55v13_ryf9091"]

remove commented out code


Copy link

review-notebook-app bot commented Jun 10, 2025

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2025-06-10T03:24:42Z
----------------------------------------------------------------

where's the plot?


ashjbarnes commented on 2025-06-13T03:44:52Z
----------------------------------------------------------------

Yeah when we're happy we should re-execute the whole notebook, then clear the output from the top cell so we have the plots, but not 1241521 messages from dask

Copy link

review-notebook-app bot commented Jun 10, 2025

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2025-06-10T03:24:42Z
----------------------------------------------------------------

is this step required?


Copy link

review-notebook-app bot commented Jun 10, 2025

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2025-06-10T03:24:43Z
----------------------------------------------------------------

Line #6.        #minimum_layers=1

why is this commented out?

if it's not needed then let's delete it

commented out code doesn't mean anything...


mmr0 commented on 2025-06-10T03:56:28Z
----------------------------------------------------------------

It throws an error with the new version. @ashjbarnes should it be replaced with something or can I just delete?

@navidcy
Copy link
Collaborator

navidcy commented Jun 10, 2025

I haven't run it yet, but I posted few comments just from glancing the PR -- thanks!

Copy link
Author

mmr0 commented Jun 10, 2025

This is a hangover from my larger domain where I needed more memory (per worker) to run `setup_initial_condition'. So, 7 is not a special number. It might be more useful to revert to 1 but add a comment. Here's the relevant thread:

COSIMA/regional-mom6#215 (comment)


View entire conversation on ReviewNB

Copy link
Author

mmr0 commented Jun 10, 2025

It throws an error with the new version. @ashjbarnes should it be replaced with something or can I just delete?


View entire conversation on ReviewNB

@ashjbarnes
Copy link
Collaborator

It throws an error with the new version. @ashjbarnes should it be replaced with something or can I just delete?

View entire conversation on ReviewNB

Yeah the functions have been changed so that 'minimum layers' is replaced with 'minimum depth', and this is implemented at the initialisation of the experiment rather than at the bathymetry step now.

The ACCESS-OM2 forced notebook should be identical to the demo in the package where possible, as this demo notebook is part of the github testing so will always work with latest version

https://github.com/COSIMA/regional-mom6/blob/main/demos/reanalysis-forced.ipynb

Copy link
Collaborator

Yeah when we're happy we should re-execute the whole notebook, then clear the output from the top cell so we have the plots, but not 1241521 messages from dask


View entire conversation on ReviewNB

@ashjbarnes
Copy link
Collaborator

This looks good, thanks @mmr0 ! I'm happy to approve the PR when

  1. Commented out code deleted as pointed out by Navid
  2. The notebook has been executed to populate the plot Navid noted are missing
  3. Outputs that we don't need has been cleared, e.g. the dask worker stuff after the first cell and some of the walls of text that rmom6 prints out after regridding and writing the config files

I wouldn't worry about handling the errors that @navidcy mentioned for the purposes of this PR, but good to keep note of them in case we need to action them later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛸 updating An existing notebook needs to be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants