-
Notifications
You must be signed in to change notification settings - Fork 70
Intake conversion SeaIce_Plot_Example #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Feel free to do it. I took a cautious approach and decided not to merge changes from main |
This PR is blocked on OM4_025.JRA_RYF not being in the Intake Catalog @adele-morrison : Is this experiment appropriate to add to the catalog? The criteria are loosely:
|
Yes, sure let's include OM4_025.JRA_RYF in the Intake Catalog. Sounds like it's at least worth keeping for the next year for OM3 development comparison. |
Now that the necessary data are in the ACCESS-NRI Intake Catalog, I've finished converting the example notebook to Intake. @anton-seaice , @adele-morrison (and anyone else interested), could you please check the notebook for correctness, and then I'll prepare it for a final merge? (You'll note I've left two additional notebooks in the Recipes directory for the moment; these are the single-model versions of the Sea Ice Coordinates notebook that I was using for development, so you can see what I had to do for each model, and then compare that to how I've combined them into the final notebook.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Results look identical to me
I have comments ... gimme a sec |
@@ -0,0 +1,5199 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #2. var_search = var_search.search(path=var_search.df['path'][0])
I think @charles-turner-1 fixed it so you don't need this workaround ?
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
@@ -0,0 +1,5199 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This operation is not technically correct due to the tripole, but works because we only sum by hemisphere. I am not sure if maybe we should make a note ?
real latitude is geolat_t
and real longitude is geolon_t
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call
@@ -0,0 +1,5199 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realise i probably wrote this but using Y instead of latitude would be less misleading. (noting comment above about tripole)
Reply via ReviewNB
@@ -0,0 +1,5199 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -0,0 +1,5199 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Oh - the readme says
Presumably this notebook only works with conda/analysis3 from xp65, and a 25.0x version? So we need to update the readme ... the cosima cookbook recipes need 24.07 and the intake ones often need newer (I think ?) |
Second oh - I think the intention here is that the user selects CICE5 or SIS, rather than have two whole copies of the recipe here |
Updated notebook runs the whole way through with no issues. |
When I try to run this using
? |
Can you try with 25.05? I think what you're seeing is a node communication error, 24.04 had some issues with |
Result is the same with 25.05 |
Not sure what happened here. I'll let you resolve the conflicts @charles-turner-1 |
@charles-turner-1 - I made the changes I wanted to make. Can you try running this and commit a clean run of the notebook ? Thanks |
@anton-seaice I think this is ready to go, can you just double check for me? I merged in the version of |
View / edit / reply to this conversation on ReviewNB anton-seaice commented on 2025-06-05T00:10:19Z It looks like Sea ice coordinates is the preferred name (and maybe change in between the start of this PR and now) |
I dont understand what is going on with fc0877b Like you've committed something to Sea_Ice_Seasonality_Statistics.ipynb but it doesn't show in the diff? Maybe do a hard reset (from main) on just that file? |
I just merged in the version from main - I'd added some info about environment versions which had disappeared for whatever reason. If you can't see anything (without screwing around with |
Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.
A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.