Skip to content

Prefer stride(i) instead of stride_i() #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Prefer stride(i) instead of stride_i() #827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/ddc/kernels/splines/kokkos-kernels-ext/KokkosBatched_Gbtrs_Serial_Impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ struct SerialGbtrs<Trans::Transpose, Algo::Level3::Unblocked> {

[[maybe_unused]] auto info_gemv =
KokkosBlas::Impl::SerialGemvInternal<Algo::Gemv::Unblocked>::invoke(
1, a.extent(0), -1.0, a.data(), a.stride_0(), a.stride_0(),
x.data(), x.stride_0(), 1.0, y.data(), y.stride_0());
1, a.extent(0), -1.0, a.data(), a.stride(0), a.stride(0),
x.data(), x.stride(0), 1.0, y.data(), y.stride(0));

// If pivot index is not j, swap rows l and j in b
auto l = piv(j);
Expand Down
4 changes: 2 additions & 2 deletions include/ddc/kernels/splines/splines_linear_problem_sparse.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,15 @@ auto to_gko_dense(std::shared_ptr<const gko::Executor> const& gko_exec, KokkosVi
static_assert((Kokkos::is_view_v<KokkosViewType> && KokkosViewType::rank == 2));
using value_type = typename KokkosViewType::traits::value_type;

if (view.stride_1() != 1) {
if (view.stride(1) != 1) {
throw std::runtime_error("The view needs to be contiguous in the second dimension");
}

return gko::matrix::Dense<value_type>::
create(gko_exec,
gko::dim<2>(view.extent(0), view.extent(1)),
gko::array<value_type>::view(gko_exec, view.span(), view.data()),
view.stride_0());
view.stride(0));
}

/**
Expand Down