Skip to content

Prefer stride(i) instead of stride_i() #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

Prefer stride(i) instead of stride_i() #827

merged 1 commit into from
Apr 16, 2025

Conversation

tpadioleau
Copy link
Member

@tpadioleau tpadioleau commented Apr 16, 2025 •
edited
Loading

I made a quick review, I think we don't have dangerous calls to stride(i). We don't have functions that allow multiple ranks.

@tpadioleau tpadioleau linked an issue Apr 16, 2025 that may be closed by this pull request
Sanitize extent and stride usage of Kokkos::View #826
Closed
@tpadioleau tpadioleau self-assigned this Apr 16, 2025
@tpadioleau tpadioleau requested a review from yasahi-hpc April 16, 2025 15:45
yasahi-hpc
yasahi-hpc approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@yasahi-hpc yasahi-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Regarding internal Gbtrs, do you have a plan to suppress this in the future? All the serial solvers are available after KK 4.7.

@tpadioleau
Copy link
Member Author

LGTM. Regarding internal Gbtrs, do you have a plan to suppress this in the future? All the serial solvers are available after KK 4.7.

I think last time we agreed on waiting the release that will have all these solvers. So if 4.7 has them all, that is fine to me.

@yasahi-hpc
Copy link
Member

Sounds good

@tpadioleau tpadioleau merged commit abaa20c into main Apr 16, 2025
65 checks passed
@tpadioleau tpadioleau deleted the 826-sanitize-extent-and-stride-usage-of-kokkosview branch April 16, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasahi-hpc yasahi-hpc yasahi-hpc approved these changes

Assignees

@tpadioleau tpadioleau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sanitize extent and stride usage of Kokkos::View
2 participants
@tpadioleau @yasahi-hpc