Skip to content

Remove tours #15999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions packages/backend-core/src/events/publishers/user.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import {
UserPermissionAssignedEvent,
UserPermissionRemovedEvent,
UserUpdatedEvent,
UserOnboardingEvent,
} from "@budibase/types"
import { isScim } from "../../context"

Expand Down Expand Up @@ -51,16 +50,6 @@ async function deleted(user: User) {
await publishEvent(Event.USER_DELETED, properties)
}

export async function onboardingComplete(user: User) {
const properties: UserOnboardingEvent = {
userId: user._id as string,
audited: {
email: user.email,
},
}
await publishEvent(Event.USER_ONBOARDING_COMPLETE, properties)
}

// PERMISSIONS

async function permissionAdminAssigned(user: User, timestamp?: number) {
Expand Down Expand Up @@ -191,7 +180,6 @@ export default {
permissionAdminRemoved,
permissionBuilderAssigned,
permissionBuilderRemoved,
onboardingComplete,
invited,
inviteAccepted,
passwordForceReset,
Expand Down
8 changes: 0 additions & 8 deletions packages/backend-core/src/users/events.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,6 @@ export const handleSaveEvents = async (
await events.user.permissionAdminRemoved(user)
}

if (isOnboardingComplete(user, existingUser)) {
await events.user.onboardingComplete(user)
}

if (
!existingUser.forceResetPassword &&
user.forceResetPassword &&
Expand Down Expand Up @@ -122,10 +118,6 @@ const isRemovingAdmin = (user: any, existingUser: any) => {
return isRemovingPermission(user, existingUser, hasAdminPermissions)
}

const isOnboardingComplete = (user: any, existingUser: any) => {
return !existingUser?.onboardedAt && typeof user.onboardedAt === "string"
}

/**
* Check if a permission is being added to a new or existing user.
*/
Expand Down
49 changes: 19 additions & 30 deletions packages/builder/src/components/deploy/AppActions.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@
sortedScreens,
appPublished,
} from "@/stores/builder"
import TourWrap from "@/components/portal/onboarding/TourWrap.svelte"
import { TOUR_STEP_KEYS } from "@/components/portal/onboarding/tours.js"
import { goto } from "@roxi/routify"

export let application
Expand Down Expand Up @@ -153,26 +151,19 @@
</div>
</div>
{/if}
<TourWrap
stepKeys={[
TOUR_STEP_KEYS.BUILDER_USER_MANAGEMENT,
TOUR_STEP_KEYS.FEATURE_USER_MANAGEMENT,
]}
>
<div class="app-action-button users">
<div class="app-action" id="builder-app-users-button">
<ActionButton
quiet
icon="UserGroup"
on:click={() => {
builderStore.showBuilderSidePanel()
}}
>
Users
</ActionButton>
</div>
<div class="app-action-button users">
<div class="app-action" id="builder-app-users-button">
<ActionButton
quiet
icon="UserGroup"
on:click={() => {
builderStore.showBuilderSidePanel()
}}
>
Users
</ActionButton>
</div>
</TourWrap>
</div>

<div class="app-action-button preview">
<div class="app-action">
Expand Down Expand Up @@ -201,15 +192,13 @@
<div bind:this={appActionPopoverAnchor}>
<div class="app-action">
<Icon name={$appPublished ? "GlobeCheck" : "GlobeStrike"} />
<TourWrap stepKeys={[TOUR_STEP_KEYS.BUILDER_APP_PUBLISH]}>
<span class="publish-open" id="builder-app-publish-button">
Publish
<Icon
name={appActionPopoverOpen ? "ChevronUp" : "ChevronDown"}
size="M"
/>
</span>
</TourWrap>
<span class="publish-open" id="builder-app-publish-button">
Publish
<Icon
name={appActionPopoverOpen ? "ChevronUp" : "ChevronDown"}
size="M"
/>
</span>
</div>
</div>
<Popover
Expand Down
167 changes: 0 additions & 167 deletions packages/builder/src/components/portal/onboarding/TourPopover.svelte

This file was deleted.

64 changes: 0 additions & 64 deletions packages/builder/src/components/portal/onboarding/TourWrap.svelte

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading