Skip to content

Remove tours #15999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 7, 2025
Merged

Remove tours #15999

merged 9 commits into from
May 7, 2025

Conversation

aptkingston
Copy link
Member

@aptkingston aptkingston commented Apr 23, 2025 •
edited
Loading

Description

This PR removes all code relating to the tours we previously used for some basic onboarding and a couple of features. We haven't updated these in a long time so we're removing them.

Feature branch env

Feature Branch Link

@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Apr 23, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@aptkingston aptkingston added the feature-branch Release this PR code into a feature branch label Apr 23, 2025
@aptkingston aptkingston changed the title Remove onboarding and feature tours Remove tours Apr 24, 2025
@github-actions github-actions bot added size/l and removed size/m labels Apr 24, 2025
@github-actions github-actions bot added the stale label May 1, 2025
@aptkingston aptkingston marked this pull request as ready for review May 2, 2025 06:37
@github-actions github-actions bot removed the stale label May 2, 2025
@aptkingston aptkingston requested a review from deanhannigan May 2, 2025 07:25
deanhannigan
deanhannigan reviewed May 2, 2025
View reviewed changes
Copy link
Contributor

@deanhannigan deanhannigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to remove everything around onboardedAt on the user/auth object if tours are removed?

// ../backend-core/src/users/events.ts
await events.user.onboardingComplete(user)

@aptkingston aptkingston requested a review from a team as a code owner May 7, 2025 14:23
@aptkingston aptkingston requested review from samwho and removed request for a team May 7, 2025 14:23
@aptkingston
Copy link
Member Author

Do we also need to remove everything around onboardedAt on the user/auth object if tours are removed?

// ../backend-core/src/users/events.ts
await events.user.onboardingComplete(user)

Nice catch, should be removed now!

deanhannigan
deanhannigan approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@deanhannigan deanhannigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

samwho
samwho approved these changes May 7, 2025
View reviewed changes
Copy link
Collaborator

@samwho samwho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for the few back-end changes that there are.

@aptkingston aptkingston enabled auto-merge May 7, 2025 15:03
@aptkingston aptkingston merged commit a93aee8 into master May 7, 2025
22 checks passed
@aptkingston aptkingston deleted the remove-tour branch May 7, 2025 15:14
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samwho samwho samwho approved these changes

@deanhannigan deanhannigan deanhannigan approved these changes

Assignees
No one assigned
Labels
feature-branch Release this PR code into a feature branch size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aptkingston @samwho @deanhannigan