Skip to content

ci: add ad-hoc app signature for macos target #3438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: staging-ln
Choose a base branch
from

Conversation

Beerosagos
Copy link
Collaborator

Before asking for reviews, here is a check list of the most common things you might need to consider:

  • updating the Changelog
  • writing unit tests
  • checking if your changes affect other coins or tokens in unintended ways
  • testing on multiple environments (Qt, Android, ...)
  • having an AI review your changes

@Beerosagos Beerosagos requested a review from benma July 3, 2025 11:36
@Beerosagos
Copy link
Collaborator Author

@benma this seems to fix the issue for me and @thisconnect. Here it is quite easy to test, since the previous commit artifact is blocked by mac os, but maybe it would be better to bring it directly on master. wdyt?

@@ -159,6 +159,15 @@ jobs:
./scripts/github-ci.sh qt-osx;
env:
OS_NAME: osx
- name: Ad-hoc sign BitBox.app
run: |
APP_PATH="$HOME/go/src/github.com/BitBoxSwiss/bitbox-wallet-app/frontends/qt/build/osx/BitBox.app"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused why this is the right path. Isn't the repo and build in {{github.workspace}}, which is the working dir?

Doesn't a relative path work like in other jobs then? I.e. simply frontends/qt/build/osx/BitBox.app.

If not, it would be good to use go env GOPATH instead of $HOME/go.

@benma
Copy link
Contributor

benma commented Jul 9, 2025

@benma this seems to fix the issue for me and @thisconnect. Here it is quite easy to test, since the previous commit artifact is blocked by mac os, but maybe it would be better to bring it directly on master. wdyt?

I agree this should be in master too.

Copy link
Contributor

@benma benma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please add some details to the commit message body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants