Skip to content

ci: add ad-hoc app signature for macos target #3438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: staging-ln
Choose a base branch
from
Draft

ci: add ad-hoc app signature for macos target #3438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,15 @@ jobs:
./scripts/github-ci.sh qt-osx;
env:
OS_NAME: osx
- name: Ad-hoc sign BitBox.app
run: |
APP_PATH="$HOME/go/src/github.com/BitBoxSwiss/bitbox-wallet-app/frontends/qt/build/osx/BitBox.app"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused why this is the right path. Isn't the repo and build in {{github.workspace}}, which is the working dir?

Doesn't a relative path work like in other jobs then? I.e. simply frontends/qt/build/osx/BitBox.app.

If not, it would be good to use go env GOPATH instead of $HOME/go.

echo "Signing app at $APP_PATH"
codesign --deep --force --verbose --sign - "$APP_PATH"
- name: Verify app signature
run: |
APP_PATH="$HOME/go/src/github.com/BitBoxSwiss/bitbox-wallet-app/frontends/qt/build/osx/BitBox.app"
codesign --verify --deep --strict --verbose=2 "$APP_PATH"
- name: Archive app
run: >
pushd ~/go/src/github.com/BitBoxSwiss/bitbox-wallet-app/frontends/qt/build/osx;
Expand Down
Loading