Skip to content

fix(internal_user_endpoints.py): support user with + in email on user info + handle empty string for arguments on gemini function calls #11601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 11, 2025

Conversation

krrishdholakia
Copy link
Contributor

@krrishdholakia krrishdholakia commented Jun 10, 2025

Title

  • handle user_email with + on /user/info
  • handle empty string for arguments on gemini function calls

Relevant issues

Fixes LIT-213

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • I have added a screenshot of my new test passing locally
  • My PR passes all unit tests on make test-unit
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test

Changes

  • fix(internal_user_endpoints.py): support user with + in email on user info

ensures user is correctly parsed from input

  • fix(factory.py): support vertex function call args as None

handles empty string in args for vertex gemini calls

  • docs(langfuse_integration.md): pin langfuse sdk version on docs

  • fix(vertex_ai/): return empty dict, instead of none when empty string given

  • refactor: reduce function size

  • fix: fix linting errors

  • fix: revert check

  • fix(internal_user_endpoints.py): fix check

  • test: update tests

  • test: update tests

…er info

ensures user is correctly parsed from input
Copy link

vercel bot commented Jun 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2025 4:40am

@krrishdholakia krrishdholakia merged commit 39de361 into main Jun 11, 2025
44 of 46 checks passed
@krrishdholakia krrishdholakia changed the title fix(internal_user_endpoints.py): support user with + in email on us… fix(internal_user_endpoints.py): support user with + in email on user info + handle empty string for arguments on gemini function calls Jun 11, 2025
@krrishdholakia krrishdholakia deleted the litellm_dev_06_10_2025_p1 branch June 11, 2025 05:14
stefan-- pushed a commit to stefan--/litellm that referenced this pull request Jun 12, 2025
BerriAI#11601)

* fix(internal_user_endpoints.py): support user with `+` in email on user info

ensures user is correctly parsed from input

* fix(factory.py): support vertex function call args as None

handles empty string in args for vertex gemini calls

* docs(langfuse_integration.md): pin langfuse sdk version on docs

* fix(vertex_ai/): return empty dict, instead of none when empty string given

* refactor: reduce function size

* fix: fix linting errors

* fix: revert check

* fix(internal_user_endpoints.py): fix check

* test: update tests

* test: update tests
X4tar pushed a commit to X4tar/litellm that referenced this pull request Jun 17, 2025
BerriAI#11601)

* fix(internal_user_endpoints.py): support user with `+` in email on user info

ensures user is correctly parsed from input

* fix(factory.py): support vertex function call args as None

handles empty string in args for vertex gemini calls

* docs(langfuse_integration.md): pin langfuse sdk version on docs

* fix(vertex_ai/): return empty dict, instead of none when empty string given

* refactor: reduce function size

* fix: fix linting errors

* fix: revert check

* fix(internal_user_endpoints.py): fix check

* test: update tests

* test: update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant