Skip to content

Add additional check before removing unreleased dependency tag #45481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Add additional check before removing unreleased dependency tag #45481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions eng/versioning/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,14 +200,18 @@ def load_version_map_from_file(the_file, version_map: Dict[str, CodeModule], aut
raise ValueError('Version file: {0} does not contain a non-beta or non-unreleased entry for beta_/unreleased_ library: {1}'.format(the_file, module.name))

# Unreleased dependencies have a few additional checks.
# 1. If 'auto_increment_version' is true, check if the version matches the dependency version of the library.
# If the unreleased dependency version is the same as the dependency version, flag the unreleased dependency for replacement.
# This flag will indicate to the update script that the 'unreleased_*' tag should be replaced with just '*', ex 'unreleased_core' -> 'core'.
# 1. If 'auto_increment_version' is true, check if the version matches the non-unreleased dependency
# version of the library and that the dependency version doesn't the current version.
# If that check passes, flag the unreleased dependency for replacement.
# This is to allow the update script to replace the 'unreleased_*' tag with just '*', ex 'unreleased_core' -> 'core'.
# When the non-unreleased dependency versions match this is an indication that the library has never
# been released and there is a library outside the /sdk/<group> directory that has a development
# on it.
# 2. Check to see that the version matches the current version of the library.
# If it isn't raise an error as unreleased dependencies should match the current version of the library.
if is_unreleased:
non_unreleased_module = version_map[tempName]
if auto_increment_version and module.dependency == non_unreleased_module.dependency:
if auto_increment_version and module.dependency == non_unreleased_module.dependency and non_unreleased_module.current != non_unreleased_module.dependency:
module.replace_unreleased_dependency = True
file_changed = True
elif module.dependency != non_unreleased_module.current:
Expand Down