Skip to content

Add additional check before removing unreleased dependency tag #45481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alzimmermsft
Copy link
Member

Description

Small follow-up fix to #45427

This PR adds an additional check before flagging an unreleased_ dependency for removal where it validates that the non-unreleased_ dependency tag doesn't have matching dependency and current versions. When there is an unreleased_ dependency for a library in that state it means that the library has never been released but a library in a different group depends on it for development. This should be a rare case that only happens when many new libraries are being added at once.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft self-assigned this May 27, 2025
@Copilot Copilot AI review requested due to automatic review settings May 27, 2025 13:55
@alzimmermsft alzimmermsft added the EngSys This issue is impacting the engineering system. label May 27, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an extra check before replacing an unreleased dependency tag to ensure that the non-unreleased dependency’s current version does not match its dependency version.

  • Updated inline comments to describe the new logic more clearly
  • Modified the condition to flag an unreleased dependency for replacement only when the non-unreleased module’s current version differs from its dependency version

@alzimmermsft alzimmermsft merged commit a687209 into Azure:main May 27, 2025
33 checks passed
@alzimmermsft alzimmermsft deleted the AzEng_SmallFixToVersionUpdateScript branch May 27, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants