Skip to content

chore: deprecate TraceDataset #7449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 87 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
6a8418d
Create annotation configs feature branch
anticorrelator Feb 21, 2025
d863633
feat: Allow multiple annotations per span with the same name (#6573)
anticorrelator Feb 28, 2025
abf528c
feat: Annotation Configurations (#6495)
anticorrelator Mar 19, 2025
9256d0a
fix(annotation-configs): make mutations read-only (#6850)
axiomofjoy Mar 20, 2025
e1e0cef
feat(annotations): Annotation Config UI (#6856)
cephalization Mar 24, 2025
1c8d9b9
feat: mutation to remove project annotation config association (#6889)
axiomofjoy Mar 24, 2025
050a1b8
feat!: db table for trace data retention policies (#6703)
RogerHYang Mar 25, 2025
da19da1
feat: graphql queries for trace retention policy CRUD operations (#6875)
RogerHYang Mar 25, 2025
2fe2864
fix(ui): fix import for react router (#6913)
mikeldking Mar 25, 2025
f15c019
feat: Add input for configuring global retention policy (#6957)
cephalization Apr 1, 2025
f5d9d27
refactor(annotations): annotation config base (#6971)
mikeldking Apr 1, 2025
c822066
refactor(annotations): move continuous to inherit (#6974)
mikeldking Apr 1, 2025
67a06e6
feat(annotations): project annotation config (#6970)
mikeldking Apr 1, 2025
80a9c31
unassociate fix (#6977)
axiomofjoy Apr 1, 2025
e3733e9
fix(annotations): add fields to annotations table (#6933)
axiomofjoy Apr 2, 2025
709e83e
feat(annotations): add timestamps to annotation gql type (#7076)
mikeldking Apr 8, 2025
c5756cd
feat(annotations): add notes UI (#7074)
mikeldking Apr 9, 2025
e44c236
feat(annotations): Implement annotation config form elements (#7063)
cephalization Apr 9, 2025
727c3f1
chore: update openapi schema
mikeldking Apr 9, 2025
09bdd6f
feat(annotations): full annotations table (#7097)
mikeldking Apr 9, 2025
97ca59f
feat(retention): Add capability based access to retention policy (#7098)
cephalization Apr 9, 2025
9154d8f
ci: fix tests (#7101)
RogerHYang Apr 10, 2025
7db382c
feat(annotations): Associate annotation configs from span aside (#7096)
cephalization Apr 10, 2025
512ed04
feat(annotations): span annotation filters (#7109)
axiomofjoy Apr 10, 2025
7f86f50
feat(admin): system level retention policies table (#7130)
mikeldking Apr 11, 2025
5c5e615
feat: graphql query for annotation summaries per span (#7129)
RogerHYang Apr 15, 2025
775aa3a
feat(admin): create retention policy UI (#7145)
mikeldking Apr 15, 2025
8ff5ae6
feat(admin): project retention policy for admins (#7162)
mikeldking Apr 17, 2025
2fc44fb
feat(annotations): Annotate spans based on project annotation configs…
cephalization Apr 18, 2025
68f8c59
feat: Upsert on annotation identifier conflict (#7082)
anticorrelator Apr 20, 2025
387f6fa
fix: forbid deletion of default policy (#7220)
RogerHYang Apr 21, 2025
ba7eb03
refactor(annotations): use json column for annotation configs (#7209)
axiomofjoy Apr 21, 2025
b527512
feat(admin): add the ability to edit / delete retention policies (#7225)
mikeldking Apr 21, 2025
751b3a0
refactor(annotations): make single mutations for creating and updatin…
axiomofjoy Apr 21, 2025
3f690c0
fix: forbid renaming of default policy (#7221)
RogerHYang Apr 22, 2025
6a8d864
fix: Unique annotation per user (#7238)
anticorrelator Apr 22, 2025
f3ae904
fix(annotations): Truncate long category names in annotation config t…
cephalization Apr 22, 2025
c290cb0
fix(annotations): ensure create annotation mutations do not upsert (#…
axiomofjoy Apr 22, 2025
22cf1d1
fix(annotations): validate values for categorical annotation config (…
axiomofjoy Apr 22, 2025
65c3750
refactor(annotations): allow batch deletion of annotation configs (#7…
axiomofjoy Apr 22, 2025
398d938
test(annotations): add tests for graphql mutations for annotation con…
axiomofjoy Apr 23, 2025
001c1bf
fix(annotations): allow `None` optimization direction (#7258)
axiomofjoy Apr 23, 2025
e2d1181
feat: Add span comment mutation (#7260)
anticorrelator Apr 23, 2025
faaacf6
feat: Reserve note annotation name (#7274)
anticorrelator Apr 24, 2025
07cd903
feat(ui): add a link to all retention policies on the settings genera…
mikeldking Apr 24, 2025
04e121b
feat(annotations): make the project annotation config more clear (#7281)
mikeldking Apr 24, 2025
7e1ff31
fix: db migrate from JSONB to JSON (#7289)
RogerHYang Apr 25, 2025
830fb59
feat: Span note resolver (#7276)
anticorrelator Apr 25, 2025
8b8748b
consolidate annotation migrations (#7282)
axiomofjoy Apr 25, 2025
2578180
refactor(annotations): consolidate rest routes (#7292)
axiomofjoy Apr 26, 2025
fcb96ec
paginate list annotation configs route (#7302)
axiomofjoy Apr 28, 2025
00c7b4c
fix(admin): make retention days step 1 (#7344)
mikeldking Apr 29, 2025
12f97ce
feat(annotations): Summarize annotations on spans, tables, project he…
cephalization Apr 29, 2025
3e1a5a6
feat: Add get span annotations route (#7339)
anticorrelator Apr 29, 2025
a0228b9
feat: Summarize dynamic annotation columns (#7346)
cephalization Apr 29, 2025
afbe543
test(annotations): improve tests for annotation config rest and graph…
axiomofjoy Apr 30, 2025
4860357
fix: firefox table css compat (#7356)
cephalization Apr 30, 2025
5e8fa56
feat: span annotation POST methods for client (#7359)
RogerHYang Apr 30, 2025
c987f9e
fix(annotations): Show 0 scores in summary labels (#7371)
cephalization Apr 30, 2025
c397497
refactor(annotations): Use dedicated createSpanNote mutation in note …
cephalization Apr 30, 2025
f5be0e4
refactor: use leading visual for icons (#7373)
mikeldking Apr 30, 2025
e59051b
feat(annotations): Paginate between traces on spans table or traces t…
cephalization May 1, 2025
b38a7ac
chore: use phoenix client in notebook for human feedback (#7369)
RogerHYang May 1, 2025
044044f
test: ensure 0 score for annotation is not treated as falsey (#7365)
RogerHYang May 1, 2025
81466ab
feat: add `get_span_annotations_dataframe` to client (#7366)
anticorrelator May 1, 2025
0378af0
feat: Stabilize categorical annotation summary pie chart colors (#7384)
cephalization May 1, 2025
c949229
refactor(annotations): use single unique constraints for identifiers …
axiomofjoy May 2, 2025
24cc2b0
Update notebook and clean up client ergonomics (#7394)
anticorrelator May 2, 2025
e9ead03
fix(annotations): Safeguard against null spanAnnotationSummaries (#7403)
cephalization May 2, 2025
b45b944
fix: Prevent time range context error when opening trace details slid…
cephalization May 5, 2025
7e34714
feat(datasets): support json dataset upload via the ui (#7410)
axiomofjoy May 5, 2025
e466d2f
feat(annotations): ensure all span annotations are included in datase…
axiomofjoy May 5, 2025
ec3489b
chore: update plpgsql script for span annotations to include identifi…
RogerHYang May 5, 2025
999fb2e
ci: clean notebook (#7423)
axiomofjoy May 5, 2025
1753e74
fix(annotations): ensure user identifiers are stable (#7414)
axiomofjoy May 5, 2025
2005d39
fix: use leading visual for the icon (#7427)
mikeldking May 5, 2025
d1d3e3e
ci: phoenix client ci (#7429)
axiomofjoy May 6, 2025
937f74b
feat: style keyboard tokens to look more like keys (#7442)
mikeldking May 6, 2025
d7f1001
fix: Polish annotations UI (#7439)
cephalization May 6, 2025
a1e1582
fix(annotations): ensure response types for annotation configs are ne…
axiomofjoy May 6, 2025
e696bda
feat(ui): Group component with refactored pagination buttons (#7444)
mikeldking May 6, 2025
6c2312c
feat: Add sorting to span annotations table (#7445)
cephalization May 6, 2025
ee9ef24
fix(annotations): Write to annotation explanation instead of label fo…
cephalization May 6, 2025
167b6ce
refactor(annotations): revert upsert logic (#7447)
axiomofjoy May 6, 2025
df89954
fix: Avoid division by zero (#7446)
anticorrelator May 6, 2025
58d1282
add deprecation warning
axiomofjoy May 6, 2025
532bc10
nix notebooks
axiomofjoy May 6, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docker-build-experimental.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Publish experimental Docker image
on:
push:
branches:
- span-query-optimization
- feat/annotations

jobs:
push_to_registry:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/playwright.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: Playwright Tests

on:
push:
branches: [main, prompts]
branches: [main, feat/annotations]
pull_request:
branches: [main, prompts]
branches: [main, feat/annotations]
jobs:
e2e-test:
timeout-minutes: 60
Expand Down
24 changes: 17 additions & 7 deletions .github/workflows/python-CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@ name: Python CI

on:
push:
branches: [main, sessions]
branches: [main, feat/annotations]
pull_request:
paths:
- "**/*.py"
- "**/*.ipynb"
- "src/**"
- "tests/**"
- "tutorials/**"
Expand Down Expand Up @@ -62,6 +63,15 @@ jobs:
phoenix_otel:
- "packages/phoenix-otel/**"
- "tox.ini"
- name: Print Filters
run: |
echo "ipynb: ${{ steps.filter.outputs.ipynb }}"
echo "ipynb_files: ${{ steps.filter.outputs.ipynb_files }}"
echo "proto: ${{ steps.filter.outputs.proto }}"
echo "phoenix: ${{ steps.filter.outputs.phoenix }}"
echo "phoenix_client: ${{ steps.filter.outputs.phoenix_client }}"
echo "phoenix_evals: ${{ steps.filter.outputs.phoenix_evals }}"
echo "phoenix_otel: ${{ steps.filter.outputs.phoenix_otel }}"

phoenix-client:
name: Phoenix Client
Expand All @@ -70,8 +80,8 @@ jobs:
if: ${{ needs.changes.outputs.phoenix_client == 'true' }}
strategy:
matrix:
py: [ 3.9, 3.12 ]
os: [ ubuntu-latest, windows-latest, macos-13 ]
py: [3.9, 3.12]
os: [ubuntu-latest, windows-latest, macos-13]
steps:
- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -139,8 +149,8 @@ jobs:
if: ${{ needs.changes.outputs.ipynb == 'true' }}
strategy:
matrix:
py: [ 3.13 ]
os: [ ubuntu-latest ]
py: [3.13]
os: [ubuntu-latest]
runs-on: ${{ matrix.os }}
steps:
- name: Checkout repository
Expand Down Expand Up @@ -506,8 +516,8 @@ jobs:
strategy:
fail-fast: false
matrix:
py: [ 3.9 ]
pkg: [ openai, anthropic, google_generativeai ]
py: [3.9]
pkg: [openai, anthropic, google_generativeai]
steps:
- name: Checkout repository
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/typescript-CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Typescript CI

on:
push:
branches: [main, sessions]
branches: [main, feat/annotations]
pull_request:
paths:
- "app/**"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/typescript-packages-CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Typescript Packages CI

on:
push:
branches: [main, prompts]
branches: [main, feat/annotations]
pull_request:
paths:
- "js/**"
Expand Down
4 changes: 3 additions & 1 deletion app/.storybook/preview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ const preview: Preview = {
},
},
initialGlobals: {
theme: "light",
theme: window.matchMedia("(prefers-color-scheme: dark)").matches
? "dark"
: "light",
},
decorators: [
// 👇 Defining the decorator in the preview file applies it to all stories
Expand Down
5 changes: 4 additions & 1 deletion app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
"@uiw/react-codemirror": "^4.23.0",
"codemirror-json-schema": "^0.7.8",
"copy-to-clipboard": "^3.3.3",
"cron-parser": "^5.1.1",
"cronstrue": "^2.59.0",
"d3-format": "^3.1.0",
"d3-scale-chromatic": "^3.1.0",
"d3-time-format": "^4.1.0",
Expand All @@ -40,7 +42,8 @@
"normalize.css": "^8.0.1",
"polished": "^4.3.1",
"react": "~18.3.1",
"react-aria-components": "^1.7.0",
"react-aria": "^3.38.1",
"react-aria-components": "^1.7.1",
"react-dom": "~18.3.1",
"react-error-boundary": "^4.0.13",
"react-hook-form": "^7.52.1",
Expand Down
Loading
Loading