Skip to content

chore: deprecate TraceDataset #7449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 87 commits into from
Closed

Conversation

axiomofjoy
Copy link
Contributor

resolves #7190

anticorrelator and others added 30 commits May 2, 2025 14:46
* Drop unique constraint migration

* Update /span_annotations REST route

* Update bulk inserters

* Update data loader to aggregate label fractions per span first

* Use correct kwarg name

* Use sqlite compatible migration

* Always use batch_alter_table

* Ensure that spans with an annotation aggregate labels properly

* Use auto recreate

* Re-apply SpanFilter

* Add migration to integration test

* Update OpenAPI schema

* Update traces router

* Update helper test

* Cast to floats before doing arithmetic

* Add type annotations

* Rebuild js client

* Use more robust typing

* Use a weighted avg for scores
- optimize query to not use cartesian product
- will scale very poorly as the number of labels increases

* Use properly per-span aggregated scores

* Cast to float before returning LabelFraction

* Add tests

* Remove score column from base stmt

* Use column indexing

* Improve clarity for type checker

* Fix unit test type checks
Co-authored-by: Alexander Song <axiomofjoy@gmail.com>
* feat(annotations): Annotation Config UI

* Fix style merging in AnnotationLabel

* Handle large values

* Rename card

* Persist annotation config via gql

* Convert annotation config popover to dialog

* Implement annotation selection toolbar + deletion

* Remove bad lint rule

* Replace dialog extra buttons with cancel button

* styling changes

* clean up annotation label

* Remove hover state from annotation label unless clickable
Co-authored-by: Mikyo King <mikyo@arize.com>
* temporary

* feat(annotations): add a ui to add / remove project annotations
* feat(annotations): addd notes UI to the side-bar

* cleanup

* add date

* add ci

* add changes
Additionally:

* Add react-aria package and FocusScope

* Use dark mode in storybook if OS is set to dark mode
chore: codegen on ts client

fix(annotations): fix facilitator

chore: fix text

chore: openapi and mypy fixes

chore: ruff

codegen
* feat(annotations): full annotations table

* feat(annotations): full annotation table in the feedback tab
* feat(admin): display retention policies

* memo
* rudimentary dialogue

* create the basic layout

* add validation

* Add forced refetch

* switch to paginated for now

* add mode
* feat(admin): project retention policies

* WIP

* final

* final

* cleanup

* cleanup

* cleanup

* cleanup
* Create annotation configs feature branch

* Add upsert logic to span annotation insertion

* Change trace annotation mutation as well

* Use SupportedSQLDialect enum

* Use default constraint names

* Use `create_index` for the partial constraint

* Implement backwards-compatible identifier index

* Add CODE to allowed annotator kind

* Start reorganizing migration to primarily use batch ops

* Reorganize downgrade to use batch ops

* Fix drop constraint call args

* Update constraint name

* Improve SpanAnnotation upsert logic

* Update trace annotation mutations

* Update REST route as well

* Fix constraint name in migration

* Refactor migrations

* Fix rest route

* Update test fixtures

* Add backwards compatible constraint to document annotations

* Add tests

* Add backwards compatibility test

* Remove needless fixture

* Ignore type issues on the return types

* Restructure mutation

* dedent

* decode ids outside transaction

* decode trace rowids outside session

---------

Co-authored-by: Alexander Song <axiomofjoy@gmail.com>
axiomofjoy and others added 20 commits May 2, 2025 14:58
…eover (#7418)

* fix: Prevent time range context error when opening trace details slideover

* Remove extraneous type cast
* feat: style keyboard tokens to look more like keys

* styling
* Add empty state to span annotation editor

* Set default categorical annotation config length to 2

* Refetch annotation configs when updated

* Fix settings page crash due to viewer object being unloaded

* Display falsy mean scores in tables

* Improve labels for negative continuous ranges

* Add placeholder for continuous inputs

* Rename feedback and annotation tabs

* Display errors when updating annotations/explanations fails

* Tweak explain label size and positions

* Add trace link copy button to trace details

* Exclude annotation explain button from focus manager

* Update ShareLinkButton Icon and positioning
* Avoid division by zero error

* Tweak comment

* Update ignore

* Use general type-ignore
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@axiomofjoy axiomofjoy changed the base branch from main to feat/annotations May 6, 2025 21:10
@axiomofjoy axiomofjoy changed the title fix(annotations): deprecate TraceDataset chore(annotations): deprecate TraceDataset May 6, 2025
@axiomofjoy axiomofjoy changed the title chore(annotations): deprecate TraceDataset chore: deprecate TraceDataset May 6, 2025
@axiomofjoy axiomofjoy closed this May 27, 2025
@github-project-automation github-project-automation bot moved this from 📘 Todo to ✅ Done in phoenix May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[annotations] [client] understand how new multi-annotations fits into TraceDataset
5 participants