Update requirements.txt for serial connection #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amilcarlucas
approved these changes
Sep 30, 2025
|
Can you please rebase and force push this? |
Although pymavlink supports the use of serial connections with a flight control board and utilizes a serial connection package, this information is not reflected in the requirements.txt file. Simply running "pip install -r pymavlink/requirements.txt" and attempting to use the mavutil module over serial will not work as expected.
|
Already rebased and force-pushed. Could you please approve and run the workflows? Thanks! :) |
peterbarker
reviewed
Oct 17, 2025
There was a problem hiding this comment.
As silly as this sounds, we don't actually require pyserial because it's not technically required to use pymavlink. You can create other sorts of backends that don't involve serial. This is also why the import for serial happens when you try to create a mavserial object.
If you can find somewhere to put this in as a "recommends" that would be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although pymavlink supports the use of serial connections with a flight control board and utilizes a serial connection package, this information is not reflected in the requirements.txt file.
Simply running "pip install -r pymavlink/requirements.txt" and attempting to use the mavutil module over serial will not work as expected.