Fix use of Set() in mavftp

[andyp1per]

This is not allowed in newer versions of python

[magicrub]

Shouldn't you also remove importing Set?

[peterbarker]

This is not allowed in newer versions of python

Which version of Python does it cause problems with? What happens when you try to cross this code?

Also, this is @amilcarlucas 's file :-)

[andyp1per]

It fails on 3.12

[peterbarker]

On Sat, 11 Oct 2025, Andy Piper wrote: It fails on 3.12

In what way?

[tpwrules]

I'm surprised this worked at all, a typing.Set should be very different to an actual set object... But it would be good to see an actual error, I think this is fine on my 3.12 on Linux.

[peterbarker]

@amilcarlucas can you weigh in on this, please?

It's breaking things for Andy, so we're very inclined to merge this!

[andyp1per]

Shouldn't you also remove importing Set?

Done, thanks

[peterbarker]

Needs to pass CI.

On the bright side, it has highlighted another code path which would have broken your setup when it was crossed :-)

[andyp1per]

I think this just demonstrates how time-consuming invalid requests for changes can be. Turns out the import is required by the reference to ```Set[int]`` which is both valid (its using typing.Set in the correct way) on 3.12 and required by the code. On 3.9 or later the lower case form can be used but it is not required and of course this would break 3.8 compatibility. So I am back at my original change - which is the one I tested - and is correct.