common: battery_status gets state of health field #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 8, 2024
|
This isn't going to fly apparently so a new proposal to switch to a BATTERY_INFO message is here mavlink#2070 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new state_of_health percentage field to the BATTERY_STATUS message.
DroneCAN batteries at least report and the format of this field was derived somewhat from this DroneCAN message. The largest difference between this field and the corresponding DSDL message is for MAVLink I think we should use zero for unknown instead of 127 (or is it perhaps -1) because the field is an extension.
The corresponding upstream PR is here mavlink#2069
The ArduPilot flight code PR that makes use of this change is here: ArduPilot/ardupilot#25926