Skip to content

Conversation

@vr4guid
Copy link
Contributor

@vr4guid vr4guid commented Jun 2, 2025

fix _dcm_to_euler calculation when pitch is -pi/2

@meee1
Copy link
Collaborator

meee1 commented Sep 6, 2025

all my sources indicate it was correct before this change.

@vr4guid
Copy link
Contributor Author

vr4guid commented Oct 23, 2025

This corrected the issue on our side.

@robertlong13
Copy link
Collaborator

robertlong13 commented Oct 26, 2025

This corrected the issue on our side.

How? Isn't this a non-functional change? phi is set to 0 in the previous line. Now, that raises the question of what the - phi and + phi were ever doing in these two places to begin with, but this change can't possibly have done anything, unless I'm gravely mistaken (and I might well be; I keep reading it over and over).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants