ConfigMotorTest: support Tri frames #3247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlong13
force-pushed
the
pr/motor_test_tri
branch
from
836c017 to
ce6468c
Compare
robertlong13
force-pushed
the
pr/motor_test_tri
branch
from
ce6468c to
4d43617
Compare
robertlong13
force-pushed
the
pr/motor_test_tri
branch
from
4d43617 to
0c40d62
Compare
robertlong13
force-pushed
the
pr/motor_test_tri
branch
from
0c40d62 to
91172a0
Compare
IamPete1
approved these changes
May 14, 2024
robertlong13
force-pushed
the
pr/motor_test_tri
branch
from
91172a0 to
5e77683
Compare
|
@meee1 sorry I forgot to actually request your review once the ArduPilot partner of this PR got merged. |
|
@meee1 reminder about this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support additional motor test information for tri frames. Goes along with this ArduPilot PR, and should probably not be merged until that one is.
This brings the motor test order in line with other frames. Starts with the front-right and works around clockwise, with the addition that "Motor C" controls the tilt servo, which is a little odd, but it's exactly what "Test all in sequence" does, so we should match that.