Option --no_param_auto_fetch to only fetch params on request. Preload added to menu. #939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephendade
reviewed
Jan 23, 2022
| if self.fetch_set is None: | ||
| self.fetch_set = set() | ||
| self.fetch_set.add(idx) | ||
| count += 1 | ||
|
|
||
There was a problem hiding this comment.
Extra whitespace needs to be removed
stephendade
requested changes
Jan 23, 2022
|
Code style again! I suck at this.
Thanks for the review.
/Matt
…On Mon, 24 Jan 2022 at 00:35, Stephen Dade ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In MAVProxy/modules/mavproxy_param.py
<#939 (comment)>:
> if self.fetch_set is None:
self.fetch_set = set()
self.fetch_set.add(idx)
count += 1
-
+
Extra whitespace needs to be removed
—
Reply to this email directly, view it on GitHub
<#939 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVYHM64DNWD4VV7OK4QWLUXSGCZANCNFSM5FKHVWWA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@crashmatt, are you able to fix up the whitespace issue? I'm keen to get this merged in :) |
|
I can do it but I have many other distractions right now. It is going to
be a little while before I can get back to this project.
…On Sat, 29 Jan 2022 at 04:47, Stephen Dade ***@***.***> wrote:
@crashmatt <https://github.com/crashmatt>, are you able to fix up the
whitespace issue? I'm keen to get this merged in :)
—
Reply to this email directly, view it on GitHub
<#939 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVYHOSLOA6QJO3ONGVESTUYNPMXANCNFSM5FKHVWWA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command option --no_param_auto_fetch added to prevent parameters upload.
Added console menu option for preload. This was necessary for testing.
Adding some state tracking to enable parameter fetch when requested while using this option.
Target is for use in bandwidth limited systems where parameter loading takes 5min+.