Updated version

[Nitr0-G]

Hello everyone.
This is a redesigned version of zydis-submodule-example, where its folder in "deps" is not needed, as well as itself. The .c file was updated for the new version of zydis, since the previous one was non-working, I also added a description for running under "Windows base OS"

[flobernd]

Hey @Nitr0-G, thanks for updating the example!

However, I'm not entirely sure about the removal of the "Git" submodule.

While CMake does offer the ability to dynamically fetch the dependency these days, for some users this is not the preferred method.

Inexperienced users often fail when dealing with "Git" submodules. I therefore think that we need to look at "CMake" submodules and "Git" submodules separately here, and optimally show the use of both concepts.

Any opinion about this @athre0z ?

[Nitr0-G]

Hey @Nitr0-G, thanks for updating the example!

However, I'm not entirely sure about the removal of the "Git" submodule.

While CMake does offer the ability to dynamically fetch the dependency these days, for some users this is not the preferred method.

Inexperienced users often fail when dealing with "Git" submodules. I therefore think that we need to look at "CMake" submodules and "Git" submodules separately here, and optimally show the use of both concepts.

Any opinion about this @athre0z ?

Then I propose to demonstrate the use of both options in this example

[athre0z]

Given that this repo is literally called "zydis-submodule-example", I feel that showing anything that isn't an actual example using a submodule might be rather misleading. Any repository with submodules will always have .gitmodules in the root, so even if we were to rename this repo to something else and created two directories for the both variants, it'd still be somewhat confusing. It we want to provide a FetchContent based example, perhaps it would be best to put it into a separate repository?

[Nitr0-G]

Given that this repo is literally called "zydis-submodule-example", I feel that showing anything that isn't an actual example using a submodule might be rather misleading. Any repository with submodules will always have .gitmodules in the root, so even if we were to rename this repo to something else and created two directories for the both variants, it'd still be somewhat confusing. It we want to provide a FetchContent based example, perhaps it would be best to put it into a separate repository?

So... Should I do this? I could do it. Let me know if I need to do this