Optimized operand definitions #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPERAND_DEFINITIONStable contains 8300+ entries and it's pretty big (105 KB). For comparison allDECODER_TREE_*tables combined are around 150 KB. EachZydisOperandDefinitionentry is 13 bytes and this PR reduces it to just 5 bytes. This has been achieved by moving two major size contributors to their own deduplicated tables.sizefield has been moved toOPERAND_SIZESand saves around 40 KB (just 27 entries after deduplication).opunion is nowZydisOperandDetails(OPERAND_DETAILS) which saves another 24 KB for grand total of 64 KB saved.Most importantly this also resolves zyantific/zydis#523