Fix colors not being reset on (partial) accept w/ recent ZSH (fixes #789) #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ZSH manual describes `region_highlight` as being an array in https://zsh.sourceforge.io/Doc/Release/Zsh-Line-Editor.html#Character-Highlighting, therefore the previous strategy of removing as many characters as the last suggestion is *not* the way to do it, explaining why it broke on recent ZSH versions. Replace this logic with a simple last-element delete. Keeps the `_ZSH_AUTOSUGGEST_LAST_HIGHLIGHT` variable intact since there's no downside in tracking its content, as it still used as a marker for whether a suggestion highlight was applied.
|
I can confirm that this fix solves the problem I have in #789 |
|
I had the exact same problem (the zsh-autosuggestions proposed color was not changing back although it was accepted). |
|
This commit also fixes it for me, too. I started experiencing this issue after upgrading to Ubuntu 24.04 (from 22.04) |
|
also fixes it for me, #820 |
|
What's preventing this from getting merged? |
|
Fixed for me too. Can this be merged? It's nearly a year and colors being broken for an autosuggestion plugin that relies on colors is kind of essential... |
|
I was having the same problem until I started using the code from this PR. @ericfreese any chance you have a moment to review and merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ZSH manual describes
region_highlightas being an array in https://zsh.sourceforge.io/Doc/Release/Zsh-Line-Editor.html#Character-Highlighting, therefore the previous strategy of removing as many characters as the last suggestion is not the way to do it, explaining why it broke on recent ZSH versions.Replace this logic with a simple last-element delete. Keeps the
_ZSH_AUTOSUGGEST_LAST_HIGHLIGHTvariable intact since there's no downside in tracking its content, as it still used as a marker for whether a suggestion highlight was applied.Fixes #789.