Skip to content

reduce usage of expectEqual in behavior tests #24389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeffective
Copy link
Contributor

@jeffective jeffective commented Jul 10, 2025

Does not fully close #24361 (this is only a first, simple change set)

Summary:

  • where the type of the operands allows, change expectEqual(x, y) to expect(x == y) for files in test/behavior/**
# without these changes (master branch)
$ git grep expectEqual test/behavior | wc -l
1028

# with these changes
$ git grep expectEqual test/behavior | wc -l
348

My editor was configured to re-order imports on save. Hope that isn't a huge issue.

Verification evidence:

  • the CI should pass, no new tests are introduced, only changes to existing tests

@jeffective jeffective force-pushed the 24361-reduce-expect-equal-behavior-tests branch from 2611cd9 to 86653d7 Compare July 12, 2025 21:01
@jeffective jeffective marked this pull request as ready for review July 12, 2025 21:30
@jeffective
Copy link
Contributor Author

requesting review from @alexrp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behavior tests should avoid expectEqual and friends
1 participant