Custom AssertableHtmlElement classes #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziadoz
commented
Jun 24, 2025
| @@ -41,18 +42,23 @@ public function test_assertable_html(): void | |||
| <li id="baz">Baz</li> | |||
| </ul> | |||
|
|
|||
| <!-- Custom Element --> | |||
There was a problem hiding this comment.
Need separate test methods per promoted/custom element in new PR.
ziadoz
commented
Jun 24, 2025
| * Assert only if the given input is null. | ||
| * Useful if you want to fail when a child element isn't matched before attempting to chain on more assertions. | ||
| */ | ||
| protected function assertIfNull(mixed $value, ?string $message = null): static |
There was a problem hiding this comment.
Need something like this in new PR? Maybe something that accepts a callback?
ziadoz
commented
Jun 24, 2025
| use Ziadoz\AssertableHtml\Contracts\AssertableHtmlElementMatcherInterface; | ||
| use Ziadoz\AssertableHtml\Dom\AssertableHtmlElement; | ||
|
|
||
| readonly class AssertableHtmlFormElement extends AssertableHtmlElement implements AssertableHtmlElementMatcherInterface |
There was a problem hiding this comment.
Need to port bits over from this into new PR.
ziadoz
commented
Jun 24, 2025
| /** Assert the form's hidden _method input matches the given value. */ | ||
| private function assertHiddenInputMethod(string $method, ?string $message = null): static | ||
| { | ||
| $this->assertIfNull($this->querySelector('input[type="hidden"][name="_method"]'), sprintf( |
There was a problem hiding this comment.
In new PR could this be:
$this->assertPresent('input[type="hidden"][name="_method"]')->assertAttribute('value', 'delete');
Would need to add assertPresent/Missing() aliases to assertCount() for element. Might also want an attribute case insensitive/trimmed assertion, as will be useful for GET vs get etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to return custom element assertable classes:
Investigate original upgradable element idea:
$assertableElement->upgrade()which returnsAssertableFormElement.