Add custom control plane for third-party device vendors #2438
Conversation
joseph-henry
requested review from
laduke,
rcoder,
glimberg and
adamierymenko
|
|
||
| #include <stdint.h> | ||
|
|
||
| #if UINTPTR_MAX == 0xffFFffFF | ||
| // 32-bit platform | ||
| template <typename Value_ = uint32_t> | ||
| #elif UINTPTR_MAX == 0xffFFffFFffFFffFF | ||
| // 64-bit platform | ||
| template <typename Value_ = uint64_t> | ||
| #else | ||
| #error Unknown platform - does not look either like 32-bit or 64-bit | ||
| #endif |
There was a problem hiding this comment.
So I've seen these changes in a couple of places in the prometheus imports. Nothing too horrible, for sure, but I wonder if it might be better to have these in a wrapper header just so that we don't have to modify the external stuff.
For instance, we create a <ztcounter.h> that includes this block of code, and then #include's the prometheus counter.h.
Just a thought
There was a problem hiding this comment.
Not a bad idea, but it looks like counter.h is only ever included from within prometheus so we'd have to patch prometheus to use our wrapper header.
|
httpcpplib might need updating to fix this issue: only mentioning it because the change will get reverted if when copy in a new version of the lib |
|
Should probably add an Action that at the very least builds this configuration for PRs just to make sure it's in a state that compiles. |
Noted. I can come in and fix it when we update the library. I think the vendor in question will be testing this more often and will likely let us know when it breaks. |
This change provides third-party device vendors the ability to manage ZeroTier without exposing the typical HTTPS control plane on
localhost. It can be enabled at compile-time viaZT_EXTOSDEP=1.There are minor changes to our dependencies which is not ideal but since the changes are so minor and it is so unlikely that they will change again I feel it is acceptable.