Added modern styling and file organization #3350
Conversation
|
🙏 Thanks for your pull request @arian-fallahpour, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
| @@ -0,0 +1,71 @@ | |||
| .Card { | |||
| background-color: white; | |||
There was a problem hiding this comment.
nitpick: for the consistency of the css colors, use same color formats
| @@ -10,44 +11,38 @@ const addDefaultImg = (e: any) => { | |||
| e.target.src = defaultImageDataURI | |||
| } | |||
| const Card = ({ user }: any) => { | |||
| let { id, img, name, email, jobTitle, location, links } = user | |||
| const { id, img, name, email, jobTitle, location, links } = user | |||
There was a problem hiding this comment.
nitpick: we should avoid variable name "img". It should be descriptive. What image it is?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If your PR has a merge conflict, it must be resolved before it can be merged. Thank you for your contributions. |
|
🙏 Thanks for your pull request @arian-fallahpour, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @arian-fallahpour, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
I added mordern styling that supports light/dark mode, and made the overall UI look nicer. I also grouped up the Card and CardList components with their respective CSS files, and added slight modifications to make them more readable and semantic.