Skip to content

feat(stats): add pickoffattempts to SimpleCatchingSplit model #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2024
Merged

feat(stats): add pickoffattempts to SimpleCatchingSplit model #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mlbstatsapi/models/stats/catching.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ class SimpleCatchingSplit:
sacbunts: Optional[int] = None
sacflies: Optional[int] = None
passedball: Optional[int] = None
pickoffattempts: Optional[int] = None

def __repr__(self) -> str:
kws = [f'{key}={value}' for key, value in self.__dict__.items() if value is not None]
Expand Down
2 changes: 1 addition & 1 deletion tests/external_tests/team/test_team.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def test_team_instance_id_instance_success(self):
# Team object should have attrs set
self.assertEqual(self.team.id, 133)
self.assertIsInstance(self.team, Team)
self.assertEqual(self.team.name, "Oakland Athletics")
self.assertEqual(self.team.name, "Athletics")
self.assertEqual(self.team.link, "/api/v1/teams/133")
self.assertIsInstance(self.team.sport, Sport)
self.assertIsInstance(self.team.venue, Venue)
Expand Down
Loading