arm64: isr_wrapper.S: make GICv2 usable on SMP systems #93629
+13
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GICC_IAR (GICv2) includes the source processor for SGIs in bits 12-10. Mask them away otherwise IPIs sent from any CPU other than CPU0 will be considered out of bounds. Signed-off-by: Nicolas Pitre <npitre@baylibre.com>
zephyrbot
requested review from
carlocaione,
ithinuel,
JiafeiPan,
povergoing,
SgrrZhf and
wearyzen
|
dylan-hong-nc
approved these changes
Jul 24, 2025
There was a problem hiding this comment.
Thank you for reflecting my issue report.
It seems that you have improved the solution I suggested so that it is not affected by gicv3 or higher.
I applied the modified code to my code and confirmed that SMP TESTSUITE is running normally on the board under test.
Thank you.
wearyzen
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GICC_IAR (GICv2) includes the source processor for SGIs in bits 12-10.
Mask them away otherwise IPIs sent from any CPU other than CPU0 will be
considered out of bounds.
Fixes #93545