You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed esp32 board_id extra argument.
This argument set the identifier of the esp32 board to test, as the --port argument for the esptool.py flash command, what was not correct. This commit remove the device_id fetch to compose the flash command and use the default serial port instead.
Hello @jerome-lamy, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊
fix a bug for the twister handler script generating the esptool flash
command. The 'device_id' was used to complete the esptool 'port'
argument, but esptool is expecting for the serial at this place.
This commit is adding a special case for the esp32 to fetch and add the
serial port as an argument for the flash tool.
FIXESzephyrproject-rtos#93601
Signed-off-by: jerome Lamy <jerome.lamy@savoirfairelinux.com>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jerome-lamy
force-pushed
the
twister_espressif_serial_bug
branch
from
zephyrbot
requested review from
gchwier,
golowanow,
hakehuang,
KamilxPaszkiet,
LukaszMrugala,
nashif and
PerMac
Removed esp32 board_id extra argument.
This argument set the identifier of the esp32 board to test, as the --port argument for the esptool.py flash command, what was not correct. This commit remove the device_id fetch to compose the flash command and use the default serial port instead.
FIXES #93601