net: lwm2m: Verify pmin for updated resource on notify check #93508
+34
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating a resource, the LwM2M library verified pmin attribute on all resources/objects in the observer path list and chose the smallest value. While this make sense for determining the lower-boundary for the next notification time, it could lead to unnecessary notifications being generated too early if the updated resource had a higher pmin value configured on it. Therefore, when checking notification criteria for an updated resource, check the pmin value for that resource path and if set and higher than the lowest pmin value evaluated for the observer list, use it instead. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
As lwm2m_notify_observer_path() now reads attributes for the updated resource, value_conditions_satisfied() does not need to read the attributes again, it can just reuse the already available data. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
|
SeppoTakalo
approved these changes
Jul 22, 2025
jukkar
approved these changes
Jul 24, 2025
fabiobaltieri
merged commit 1e77663
into
zephyrproject-rtos:main
37 of 39 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating a resource, the LwM2M library verified pmin attribute on
all resources/objects in the observer path list and chose the smallest
value. While this make sense for determining the lower-boundary for the
next notification time, it could lead to unnecessary notifications being
generated too early if the updated resource had a higher pmin value
configured on it.
Therefore, when checking notification criteria for an updated resource,
check the pmin value for that resource path and if set and higher than
the lowest pmin value evaluated for the observer list, use it instead.
Fixes #93315